On Thu, Jun 9, 2011 at 18:08, John D. Ament <span dir="ltr"><<a href="mailto:john.d.ament@gmail.com">john.d.ament@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
-1<br><br>In my opinion the combined jar helps keep the number of JAR files down in deployments.</blockquote><div><br></div><div># of jars really doesn't matter, it's the size of the war that matters (when we are talking about sizes). </div>
<div><br></div><div>The problem with the combined JAR is that it's too easy for a developer to inadvertently *also* add the implementation and api jars separately, and then the application goes haywire. This is a slippery slope because of transitive dependencies.</div>
<div><br></div><div>The other point that a colleague of mine pointed out is that by making a combined jar, you undermine the whole effort of having an api/impl split. And seeing how we are trying to encourage interface-based development and separation of these concerns, it's the right thing to do.</div>
<div><br></div><div>I'll also add that scanning behaves differently when you have a combined jar vs individuals. So you are introducing subtle differences that could lead to bugs.</div><div><br></div><div>-Dan</div><div>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Thu, Jun 9, 2011 at 12:54 AM, Dan Allen <span dir="ltr"><<a href="mailto:dan.j.allen@gmail.com" target="_blank">dan.j.allen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">+1<div><br></div><div>-Dan<div><div></div><div><br><br><div class="gmail_quote">On Thu, Jun 9, 2011 at 00:12, Jason Porter <span dir="ltr"><<a href="http://lightguard.jp" target="_blank">lightguard.jp</a>@<a href="http://gmail.com" target="_blank">gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">+1<div><div></div><div><br><br><div class="gmail_quote">On Wed, Jun 8, 2011 at 17:32, Shane Bryzak <span dir="ltr"><<a href="mailto:sbryzak@redhat.com" target="_blank">sbryzak@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
We discussed this briefly on IRC, however I thought we should discuss it<br>
on seam-dev before we make any concrete decision. To summarise the plan:<br>
<br>
1. Remove the combined jar file from each of the modules<br>
2. If the module has a single implementation, rename it to whatever the<br>
combined jar was called.<br>
E.g. for Seam Catch, the impl module would be called seam-catch.<br>
3. If the module has multiple implementations, then add a suffix to the<br>
artifact name that reflects the individual implementation.<br>
E.g. Seam Reports has two implementations, which would be called<br>
seam-reports-jasper (for Jasper reports) and seam-reports-pentaho (for<br>
Pentaho).<br>
4. Leave the API naming as it is, e.g. seam-reports-api.<br>
<br>
The idea is that by importing the simplified module artifact name (i.e.<br>
"seam-xxx") you would get the default implementation, which in turn<br>
depends on the API. The advantage of this is that we won't break<br>
backwards compatibility - e.g. someone currently declaring a dependency<br>
on "seam-catch" in their pom file won't have their app broken when we<br>
rename the modules. Also we remove the complexity introduced by having<br>
a combined jar in the first place.<br>
<br>
If you can spot any issues with this, please speak up now ;)<br>
<br>
Shane<br>
_______________________________________________<br>
seam-dev mailing list<br>
<a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>
</blockquote></div><br><br clear="all"><br></div></div>-- <br>Jason Porter<br><a href="http://lightguard-jp.blogspot.com" target="_blank">http://lightguard-jp.blogspot.com</a><br><a href="http://twitter.com/lightguardjp" target="_blank">http://twitter.com/lightguardjp</a><br>
<br>Software Engineer<br>Open Source Advocate<br>Author of Seam Catch - Next Generation Java Exception Handling<br><br>PGP key id: 926CCFF5<br>PGP key available at: <a href="http://keyserver.net" target="_blank">keyserver.net</a>, <a href="http://pgp.mit.edu" target="_blank">pgp.mit.edu</a><br>
<br>_______________________________________________<br>
seam-dev mailing list<br>
<a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br></div></div><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><div><a href="http://www.google.com/profiles/dan.j.allen#about" target="_blank">http://www.google.com/profiles/dan.j.allen#about</a><br>
<a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br><a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br></div><br>
</div>
<br>_______________________________________________<br>
seam-dev mailing list<br>
<a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>
<br></blockquote></div><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><div><a href="http://www.google.com/profiles/dan.j.allen#about" target="_blank">http://www.google.com/profiles/dan.j.allen#about</a><br>
<a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br><a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br></div><br>