<div>
<div>Hi all,</div><div><br></div><div>Answers inline.</div><div>
<p style="color: #a0a0a0;">Le dimanche 12 juin 2011 à 20:22, Hardy Ferentschik a écrit :</p>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">
<span><div><div>Hi all,<br><br>nice to see some new constraints :-)<br>Some more thoughts inline<br><br>On Sun, 12 Jun 2011 12:31:14 +0200, Gunnar Morling <br><<a href="mailto:gunnar.morling@googlemail.com">gunnar.morling@googlemail.com</a>> wrote:<br><br><blockquote type="cite"><div>I'm not totally sure what the right place for it would be, though. The<br>constraints we have in HV so far are independent from any application<br>layer. @WebSafe would be the first one specific to the web layer.<br></div></blockquote><br>IMO this is validator is not really application layer dependent, even <br>thought this is<br>obviously where it will be most useful. Personally I would find something <br>like SafeHtml<br>better than @WebSafe. It would also tie the constraints less to a layer. <br>IMO it also communicates<br>its purpose better.<br></div></div></span></blockquote><div><br></div><div><div>+1</div><div><br></div><div>I think that renaming the annotation will better communicates its purpose. </div><div>WebSafe is general, SafeHtml sounds good to me.</div></div><div> </div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><blockquote type="cite"><div>Maybe it would also be a good idea to have a separate library<br>exclusively for custom constraints which could be used from everywhere<br>("HV Commons" or similar).<br></div></blockquote><br>I think it is to early think about a new module/library. As said, I don't <br>see this constraints<br>necessarily tied to a layer and without at least a couple of concrete <br>layer specific constraints I<br>think we should wait.<br></div></div>></span></blockquote><div><br></div><div>I'm not sure to understand.</div><div>Why a new module could be created?</div><div> </div><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;"><span><div><div><blockquote type="cite"><div>We already have a CR for 4.2. If we decide to add @WebSafe to HV do<br>you think we should add this in 4.2 or to the next release?<br></div></blockquote><br>My initial feeling is to wait for the next release, but I don't feel to <br>strongly about this.<br>However, -1 for a new library/module and +1 for a rename of the constraint.<br><br>--Hardy<br></div></div></span></blockquote><div><br></div><div>Like Hardy my initial feeling is to wait for the next release but the pull request is</div><div>opened and it will not be very hard to integrate it in master :-) I've no strong </div><div>opinion about this. </div><div> </div>
<div>
--Kevin
</div>
</div>
</div>