Good points Dan, I'd forgotten about that.<br><br><div class="gmail_quote">On Fri, Aug 12, 2011 at 16:34, Dan Allen <span dir="ltr"><<a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">The qualifier approach is more in the spirit of the CDI design.<div><br></div><div>Plus, when you use qualifiers, you have a built-in mechanism for selection via the Instance SPI.</div>
<div><br></div><div>@Inject @Any Instance<TemplateCompiler> compilerSelector;</div>
<div><br></div><div>compilerSelector.select(new VelocityLiteral() {}).get();</div><div><br></div><div>In this way, we are building on the flexibility that CDI affords.<br><br></div><div>-Dan</div><div><div><div></div><div class="h5">
<br><div class="gmail_quote">
On Wed, Aug 10, 2011 at 14:49, Jason Porter <span dir="ltr"><<a href="mailto:lightguard.jp@gmail.com" target="_blank">lightguard.jp@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Both actually accomplish the same thing, only difference is you don't need the extra qualifier class.<br>
<br>
Sent from my iPhone<br>
<div><div></div><div><br>
On Aug 10, 2011, at 12:34, George Gastaldi <<a href="mailto:gegastaldi@gmail.com" target="_blank">gegastaldi@gmail.com</a>> wrote:<br>
<br>
> That would be better, but I think that we may use qualifiers for that,<br>
> just as is being used in Seam Reports:<br>
><br>
> Like:<br>
><br>
> @Inject @Velocity<br>
> TemplateCompiler compiler;<br>
><br>
> and then just:<br>
> compiler.compile("tpl/file.tpl");<br>
><br>
><br>
><br>
> 2011/8/10 Lincoln Baxter, III <<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>>:<br>
>> I think in Render it's a matter of refactoring the TemplateCompiler<br>
>> interface to support a TemplatingProvider service, for which you choose<br>
>> implementation with:<br>
>><br>
>> @Inject<br>
>> private TemplateCompiler<VelocityProvider> compiler;<br>
>><br>
>> or<br>
>><br>
>> @Inject<br>
>> private TemplateCompiler compiler;<br>
>><br>
>> Then<br>
>><br>
>> compiler.compile(VelocityProvider.class, "tpl/file.tpl")<br>
>><br>
>> or<br>
>><br>
>> @Inject<br>
>> private TemplateCompiler compiler;<br>
>><br>
>> @Inject<br>
>> private VelocityProvider provider;<br>
>><br>
>> Then<br>
>><br>
>> compiler.compile(provider, "tpl/file.tpl");<br>
>><br>
>> etc...<br>
>><br>
>> George, does this fit your needs?<br>
>><br>
>> ~Lincoln<br>
>><br>
>><br>
>><br>
>> On Mon, Aug 8, 2011 at 6:57 PM, Jason Porter <<a href="mailto:lightguard.jp@gmail.com" target="_blank">lightguard.jp@gmail.com</a>><br>
>> wrote:<br>
>>><br>
>>> I haven't had time to look at this yet. Perhaps you (Lincoln and George)<br>
>>> can start things off with what you think would need to change for each of<br>
>>> the modules.<br>
>>><br>
>>> On Mon, Aug 8, 2011 at 16:50, George Gastaldi <<a href="mailto:gegastaldi@gmail.com" target="_blank">gegastaldi@gmail.com</a>><br>
>>> wrote:<br>
>>>><br>
>>>> Any evolution so far ? It would be nice to get that ready before the<br>
>>>> Beta release.<br>
>>>><br>
>>>> Regards,<br>
>>>><br>
>>>> George<br>
>>>><br>
>>>> 2011/8/3 Jason Porter <<a href="mailto:lightguard.jp@gmail.com" target="_blank">lightguard.jp@gmail.com</a>>:<br>
>>>>> I need to spend some time looking at the APIs for these (Render,<br>
>>>>> Reports and<br>
>>>>> Mail) and see what needs to happen. I really like the idea of Seam<br>
>>>>> Render<br>
>>>>> being our pluggable template solution .<br>
>>>>><br>
>>>>> On Wed, Aug 3, 2011 at 15:38, Lincoln Baxter, III<br>
>>>>> <<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>><br>
>>>>> wrote:<br>
>>>>>><br>
>>>>>> Thoughts?<br>
>>>>>><br>
>>>>>> --<br>
>>>>>> Lincoln Baxter, III<br>
>>>>>> <a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br>
>>>>>> <a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
>>>>>> "Keep it Simple"<br>
>>>>>><br>
>>>>>> _______________________________________________<br>
>>>>>> seam-dev mailing list<br>
>>>>>> <a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a><br>
>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>
>>>>>><br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> --<br>
>>>>> Jason Porter<br>
>>>>> <a href="http://lightguard-jp.blogspot.com" target="_blank">http://lightguard-jp.blogspot.com</a><br>
>>>>> <a href="http://twitter.com/lightguardjp" target="_blank">http://twitter.com/lightguardjp</a><br>
>>>>><br>
>>>>> Software Engineer<br>
>>>>> Open Source Advocate<br>
>>>>> Author of Seam Catch - Next Generation Java Exception Handling<br>
>>>>><br>
>>>>> PGP key id: 926CCFF5<br>
>>>>> PGP key available at: <a href="http://keyserver.net" target="_blank">keyserver.net</a>, <a href="http://pgp.mit.edu" target="_blank">pgp.mit.edu</a><br>
>>>>><br>
>>>>> _______________________________________________<br>
>>>>> seam-dev mailing list<br>
>>>>> <a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a><br>
>>>>> <a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>
>>>>><br>
>>>>><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Jason Porter<br>
>>> <a href="http://lightguard-jp.blogspot.com" target="_blank">http://lightguard-jp.blogspot.com</a><br>
>>> <a href="http://twitter.com/lightguardjp" target="_blank">http://twitter.com/lightguardjp</a><br>
>>><br>
>>> Software Engineer<br>
>>> Open Source Advocate<br>
>>> Author of Seam Catch - Next Generation Java Exception Handling<br>
>>><br>
>>> PGP key id: 926CCFF5<br>
>>> PGP key available at: <a href="http://keyserver.net" target="_blank">keyserver.net</a>, <a href="http://pgp.mit.edu" target="_blank">pgp.mit.edu</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> Lincoln Baxter, III<br>
>> <a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br>
>> <a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
>> "Keep it Simple"<br>
>><br>
<br>
_______________________________________________<br>
seam-dev mailing list<br>
<a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br></div></div><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><div><a href="http://www.google.com/profiles/dan.j.allen#about" target="_blank">http://www.google.com/profiles/dan.j.allen#about</a><br>
<a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br><a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br></div><br>
</div>
</blockquote></div><br><br clear="all"><br>-- <br>Jason Porter<br><a href="http://lightguard-jp.blogspot.com" target="_blank">http://lightguard-jp.blogspot.com</a><br><a href="http://twitter.com/lightguardjp" target="_blank">http://twitter.com/lightguardjp</a><br>
<br>Software Engineer<br>Open Source Advocate<br>Author of Seam Catch - Next Generation Java Exception Handling<br><br>PGP key id: 926CCFF5<br>PGP key available at: <a href="http://keyserver.net" target="_blank">keyserver.net</a>, <a href="http://pgp.mit.edu" target="_blank">pgp.mit.edu</a><br>