<p>I like this a lot better than the first proposal and fixes the issue I've been whining about :-)</p>
<p>John</p>
<div class="gmail_quote">On Aug 20, 2011 7:01 PM, "Shane Bryzak" <<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a>> wrote:<br type="attribution">> We could possibly do it by specifying additional source directories for <br>
> each profile.<br>> <br>> <a href="http://chadthedeveloper.blogspot.com/2008/02/maven2-multiple-source-directories-and.html">http://chadthedeveloper.blogspot.com/2008/02/maven2-multiple-source-directories-and.html</a><br>
> <br>> On 21/08/11 08:59, Jason Porter wrote:<br>>> Can we add additional tests with this though for each container?<br>>><br>>> Sent from my iPhone<br>>><br>>> On Aug 20, 2011, at 16:35, Shane Bryzak <<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a> <br>
>> <mailto:<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a>>> wrote:<br>>><br>>>> That might be one way we can do it - Ken, what do you think about <br>>>> structuring the test suite like this?<br>
>>><br>>>> <a href="https://gist.github.com/1155271">https://gist.github.com/1155271</a><br>>>><br>>>><br>>>> On 21/08/11 08:27, Jason Porter wrote:<br>>>>> Maybe something in surefire, or what aslak said on twitter may be <br>
>>>> helpful.<br>>>>><br>>>>> Sent from my iPhone<br>>>>><br>>>>> On Aug 20, 2011, at 16:21, Shane Bryzak <<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a> <br>
>>>> <mailto:<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a>>> wrote:<br>>>>><br>>>>>> I'm currently looking into it.<br>>>>>><br>>>>>> On 21/08/11 08:04, Jason Porter wrote:<br>
>>>>>> Is it possible to add a source directory or test directory?<br>>>>>>><br>>>>>>> Sent from my iPhone<br>>>>>>><br>>>>>>> On Aug 20, 2011, at 15:36, Shane Bryzak <<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a> <br>
>>>>>> <mailto:<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a>>> wrote:<br>>>>>>><br>>>>>>>> Unfortunately that doesn't work - the issue occurs when the <br>
>>>>>>> artifacts being unpacked are in the same reactor. See <br>>>>>>>> <a href="http://jira.codehaus.org/browse/MDEP-98">http://jira.codehaus.org/browse/MDEP-98</a><br>>>>>>>><br>
>>>>>>> On 21/08/11 01:11, Ken Finnigan wrote:<br>>>>>>>>> If I'm not mistaken, that error is resolved by installing the <br>>>>>>>>> artifacts.<br>
>>>>>>>><br>>>>>>>>> The problem is that it doesn't know how to unpack a directory, <br>>>>>>>>> so the jar with the test classes needs to be installed for it to <br>
>>>>>>>> work<br>>>>>>>>><br>>>>>>>>> Ken<br>>>>>>>>><br>>>>>>>>> Sent from my iPhone<br>>>>>>>>><br>
>>>>>>>> On Aug 20, 2011, at 11:02, Shane Bryzak <<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a> <br>>>>>>>>> <mailto:<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a>>> wrote:<br>
>>>>>>>><br>>>>>>>>>> I've made some progress in this area, so far I've created a few <br>>>>>>>>>> of the container boms in seam-parent and also started <br>
>>>>>>>>> converting the Solder tests to use the new structure.<br>>>>>>>>>><br>>>>>>>>>> I have run into one issue though - when running the tests I'm <br>
>>>>>>>>> encountering the error below. The reason it hasn't manifested <br>>>>>>>>>> in the International module is because there was a version <br>>>>>>>>>> mismatch between some of the test suite artifacts, however if <br>
>>>>>>>>> you synchronize them all you get the same error.<br>>>>>>>>>><br>>>>>>>>>> [INFO] Reactor Summary:<br>>>>>>>>>> [INFO]<br>
>>>>>>>>> [INFO] Seam International Test Suite: Aggregator ......... <br>>>>>>>>>> SUCCESS [1.224s]<br>>>>>>>>>> [INFO] Seam Container BOMs Aggregator .................... <br>
>>>>>>>>> SUCCESS [0.025s]<br>>>>>>>>>> [INFO] Weld EE Embedded 1.1 Container .................... <br>>>>>>>>>> SUCCESS [0.899s]<br>>>>>>>>>> [INFO] JBoss AS7 Managed Container ....................... <br>
>>>>>>>>> SUCCESS [2.722s]<br>>>>>>>>>> [INFO] Seam International Test Suite Common .............. <br>>>>>>>>>> SUCCESS [0.376s]<br>>>>>>>>>> [INFO] Seam International Test Suite: Internals Integration <br>
>>>>>>>>> Tests SUCCESS [0.013s]<br>>>>>>>>>> [INFO] Seam International Test Suite: Internals Integration <br>>>>>>>>>> Tests Base SUCCESS [0.743s]<br>
>>>>>>>>> [INFO] Seam International Test Suite: Internals Integration <br>>>>>>>>>> Tests for JBoss AS FAILURE [2.529s]<br>>>>>>>>>> [INFO] Seam International Test Suite: Internals Integration <br>
>>>>>>>>> Tests for Weld EE Embedded SKIPPED<br>>>>>>>>>> [INFO] <br>>>>>>>>>> ------------------------------------------------------------------------<br>
>>>>>>>>> [INFO] BUILD FAILURE<br>>>>>>>>>> [INFO] <br>>>>>>>>>> ------------------------------------------------------------------------<br>
>>>>>>>>> [INFO] Total time: 9.393s<br>>>>>>>>>> [INFO] Finished at: Sun Aug 21 00:55:38 EST 2011<br>>>>>>>>>> [INFO] Final Memory: 25M/348M<br>
>>>>>>>>> [INFO] <br>>>>>>>>>> ------------------------------------------------------------------------<br>>>>>>>>>> [ERROR] Failed to execute goal <br>
>>>>>>>>> org.apache.maven.plugins:maven-dependency-plugin:2.1:unpack <br>>>>>>>>>> (unpack-base-tests) on project <br>>>>>>>>>> seam-international-testsuite-integration-internals-jbossas: <br>
>>>>>>>>> Error unpacking file: <br>>>>>>>>>> /home/shane/project/seam/international/testsuite/internals/base/target/classes <br>>>>>>>>>> to: <br>
>>>>>>>>> /home/shane/project/seam/international/testsuite/internals/jbossas/target/test-classes<br>>>>>>>>>> [ERROR] org.codehaus.plexus.archiver.ArchiverException: The <br>
>>>>>>>>> source must not be a directory.<br>>>>>>>>>> [ERROR] -> [Help 1]<br>>>>>>>>>><br>>>>>>>>>><br>>>>>>>>>> I've spent a little time trying to find a workaround but it <br>
>>>>>>>>> seems that this has been a known bug in Maven for at least 4 <br>>>>>>>>>> years. If anyone wants to take a look at this and try to <br>>>>>>>>>> figure out a workaround in the meantime please be my guest.<br>
>>>>>>>>><br>>>>>>>>>> Shane<br>>>>>>>>>><br>>>>>>>>>><br>>>>>>>>>> On 30/07/11 12:16, Ken Finnigan wrote:<br>
>>>>>>>>>> All,<br>>>>>>>>>>><br>>>>>>>>>>> I've committed the work on the Arquillian testsuite <br>>>>>>>>>>> infrastructure on the i18n module which can be found here: <br>
>>>>>>>>>> <a href="https://github.com/seam/international/tree/develop/testsuite">https://github.com/seam/international/tree/develop/testsuite</a><br>>>>>>>>>>><br>
>>>>>>>>>> Here are some notes on how it's structured and what needs to <br>>>>>>>>>>> be done:<br>>>>>>>>>>><br>>>>>>>>>>> * API and Impl modules still retain unit tests that don't<br>
>>>>>>>>>> require container testing<br>>>>>>>>>>> * testsuite/common includes Deployment and Library helpers<br>>>>>>>>>>> and anything that would be common to multiple types of<br>
>>>>>>>>>> testsuites, such as internals, smoke, etc<br>>>>>>>>>>> o The helpers from this module could potentially be<br>>>>>>>>>>> pulled up into a common module for all, but that may<br>
>>>>>>>>>> introduce complexity in trying to use it in each<br>>>>>>>>>>> module so may be best to leave it there for the moment<br>>>>>>>>>>> and see how it goes<br>
>>>>>>>>>> * testsuite/container-boms contains the container definition<br>>>>>>>>>>> for weld ee embedded and AS7. Others can be found at<br>>>>>>>>>>> <a href="https://github.com/mojavelinux/arquillian-showcase/tree/master/container-boms">https://github.com/mojavelinux/arquillian-showcase/tree/master/container-boms</a><br>
>>>>>>>>>> o One of the first things that needs to happen is these<br>>>>>>>>>>> container-boms need to be created in a seam parent<br>>>>>>>>>>> module of some kind such that each module can utilize<br>
>>>>>>>>>> them without having to replicate the content directly<br>>>>>>>>>>> * testsuite/internals/base contains the test classes that<br>>>>>>>>>>> used to be within impl. For i18n I was able to leave the<br>
>>>>>>>>>> entirety of the test classes in the bases module and<br>>>>>>>>>>> simply explode it into the target/test-classes directory<br>>>>>>>>>>> of the testsuite/internals/${container} modules as part of<br>
>>>>>>>>>> the integration-test phase.<br>>>>>>>>>>> o To make it easier to then explode the jar built from<br>>>>>>>>>>> this module into sub modules, the test classes and<br>
>>>>>>>>>> resources actually need to be in src/main. As we<br>>>>>>>>>>> don't plan using the jar built from this for anything<br>>>>>>>>>>> other than testing it's not an issue.<br>
>>>>>>>>>> * container tests are only activated on the integration-test<br>>>>>>>>>>> phase and skipped on the basic test phase<br>>>>>>>>>>> * <a href="https://github.com/seam/international/blob/develop/testsuite/README.md">https://github.com/seam/international/blob/develop/testsuite/README.md</a><br>
>>>>>>>>>> outlines all the proposed types of suites that testsuite<br>>>>>>>>>>> can contain. I believe an initial first step should be to<br>>>>>>>>>>> move the existing container tests, or create some, for the<br>
>>>>>>>>>> internals module. Over time we can then look to flesh out<br>>>>>>>>>>> the testsuite with additional types such as smoke,<br>>>>>>>>>>> cluster, api, etc<br>
>>>>>>>>>> * One area that I haven't looked at yet is code coverage<br>>>>>>>>>>> given that the tests are further spread than previously. <br>>>>>>>>>>> I'm hoping that it will be relatively easy to amalgamate<br>
>>>>>>>>>> all the coverage data to produce a single report.<br>>>>>>>>>>><br>>>>>>>>>>> Any questions about this please let me know.<br>
>>>>>>>>>><br>>>>>>>>>>> Ken<br>>>>>>>>>>><br>>>>>>>>>>><br>>>>>>>>>>> _______________________________________________<br>
>>>>>>>>>> seam-dev mailing list<br>>>>>>>>>>> <a href="mailto:seam-dev@lists.jboss.org">seam-dev@lists.jboss.org</a> <mailto:<a href="mailto:seam-dev@lists.jboss.org">seam-dev@lists.jboss.org</a>><br>
>>>>>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/seam-dev">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>>>>>>>>>><br>>>>>>>><br>
>>>>>>> _______________________________________________<br>>>>>>>> seam-dev mailing list<br>>>>>>>> <a href="mailto:seam-dev@lists.jboss.org">seam-dev@lists.jboss.org</a> <mailto:<a href="mailto:seam-dev@lists.jboss.org">seam-dev@lists.jboss.org</a>><br>
>>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/seam-dev">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>>>>>><br>>>><br>> <br></div>