That would be my preference. As much as possible for versioning in seam-parent.<br><br>I did look closer at what Aslak posted. It looks like the underlying capabilities are based on a modification to surefire. The patch itself that he sent doesn't compile though.<br>
<br><div class="gmail_quote">On Sun, Aug 21, 2011 at 7:42 AM, Shane Bryzak <span dir="ltr"><<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div text="#000000" bgcolor="#FFFFFF">
Hmm, actually what do you guys think about putting the profile
dependencies for these into seam-parent? It would certainly
simplify configuring tests across all the modules.<div><div></div><div class="h5"><br>
<br>
On 21/08/11 08:35, Shane Bryzak wrote:
<blockquote type="cite">
That might be one way we can do it - Ken, what do you think about
structuring the test suite like this?<br>
<br>
<a href="https://gist.github.com/1155271" target="_blank">https://gist.github.com/1155271</a><br>
<br>
<br>
On 21/08/11 08:27, Jason Porter wrote:
<blockquote type="cite">
<div>Maybe something in surefire, or what aslak said on twitter
may be helpful. <br>
<br>
Sent from my iPhone</div>
<div><br>
On Aug 20, 2011, at 16:21, Shane Bryzak <<a href="mailto:sbryzak@redhat.com" target="_blank">sbryzak@redhat.com</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div> I'm currently looking into it.<br>
<br>
On 21/08/11 08:04, Jason Porter wrote:
<blockquote type="cite">
<div>Is it possible to add a source directory or test
directory?<br>
<br>
Sent from my iPhone</div>
<div><br>
On Aug 20, 2011, at 15:36, Shane Bryzak <<a href="mailto:sbryzak@redhat.com" target="_blank">sbryzak@redhat.com</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div> Unfortunately that doesn't work - the issue occurs
when the artifacts being unpacked are in the same
reactor. See <a href="http://jira.codehaus.org/browse/MDEP-98" target="_blank">http://jira.codehaus.org/browse/MDEP-98</a><br>
<br>
On 21/08/11 01:11, Ken Finnigan wrote:
<blockquote type="cite">
<div>If I'm not mistaken, that error is resolved by
installing the artifacts.</div>
<div><br>
</div>
<div>The problem is that it doesn't know how to
unpack a directory, so the jar with the test
classes needs to be installed for it to work</div>
<div><br>
</div>
<div>Ken<br>
<br>
Sent from my iPhone</div>
<div><br>
On Aug 20, 2011, at 11:02, Shane Bryzak <<a href="mailto:sbryzak@redhat.com" target="_blank">sbryzak@redhat.com</a>>
wrote:<br>
<br>
</div>
<blockquote type="cite">
<div> I've made some progress in this area, so far
I've created a few of the container boms in
seam-parent and also started converting the
Solder tests to use the new structure.<br>
<br>
I have run into one issue though - when running
the tests I'm encountering the error below. The
reason it hasn't manifested in the International
module is because there was a version mismatch
between some of the test suite artifacts,
however if you synchronize them all you get the
same error.<br>
<br>
[INFO] Reactor Summary:<br>
[INFO] <br>
[INFO] Seam International Test Suite: Aggregator
......... SUCCESS [1.224s]<br>
[INFO] Seam Container BOMs Aggregator
.................... SUCCESS [0.025s]<br>
[INFO] Weld EE Embedded 1.1 Container
.................... SUCCESS [0.899s]<br>
[INFO] JBoss AS7 Managed Container
....................... SUCCESS [2.722s]<br>
[INFO] Seam International Test Suite Common
.............. SUCCESS [0.376s]<br>
[INFO] Seam International Test Suite: Internals
Integration Tests SUCCESS [0.013s]<br>
[INFO] Seam International Test Suite: Internals
Integration Tests Base SUCCESS [0.743s]<br>
[INFO] Seam International Test Suite: Internals
Integration Tests for JBoss AS FAILURE [2.529s]<br>
[INFO] Seam International Test Suite: Internals
Integration Tests for Weld EE Embedded SKIPPED<br>
[INFO]
------------------------------------------------------------------------<br>
[INFO] BUILD FAILURE<br>
[INFO]
------------------------------------------------------------------------<br>
[INFO] Total time: 9.393s<br>
[INFO] Finished at: Sun Aug 21 00:55:38 EST 2011<br>
[INFO] Final Memory: 25M/348M<br>
[INFO]
------------------------------------------------------------------------<br>
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-dependency-plugin:2.1:unpack
(unpack-base-tests) on project
seam-international-testsuite-integration-internals-jbossas:
Error unpacking file:
/home/shane/project/seam/international/testsuite/internals/base/target/classes
to:
/home/shane/project/seam/international/testsuite/internals/jbossas/target/test-classes<br>
[ERROR]
org.codehaus.plexus.archiver.ArchiverException:
The source must not be a directory.<br>
[ERROR] -> [Help 1]<br>
<br>
<br>
I've spent a little time trying to find a
workaround but it seems that this has been a
known bug in Maven for at least 4 years. If
anyone wants to take a look at this and try to
figure out a workaround in the meantime please
be my guest.<br>
<br>
Shane<br>
<br>
<br>
On 30/07/11 12:16, Ken Finnigan wrote:
<blockquote type="cite">All,<br>
<br>
I've committed the work on the Arquillian
testsuite infrastructure on the i18n module
which can be found here: <a href="https://github.com/seam/international/tree/develop/testsuite" target="_blank">https://github.com/seam/international/tree/develop/testsuite</a><br>
<br>
Here are some notes on how it's structured and
what needs to be done:<br>
<br>
<ul>
<li>API and Impl modules still retain unit
tests that don't require container testing</li>
<li>testsuite/common includes Deployment and
Library helpers and anything that would be
common to multiple types of testsuites,
such as internals, smoke, etc</li>
<ul>
<li>The helpers from this module could
potentially be pulled up into a common
module for all, but that may introduce
complexity in trying to use it in each
module so may be best to leave it there
for the moment and see how it goes</li>
</ul>
<li>testsuite/container-boms contains the
container definition for weld ee embedded
and AS7. Others can be found at <a href="https://github.com/mojavelinux/arquillian-showcase/tree/master/container-boms" target="_blank">https://github.com/mojavelinux/arquillian-showcase/tree/master/container-boms</a></li>
<ul>
<li>One of the first things that needs to
happen is these container-boms need to
be created in a seam parent module of
some kind such that each module can
utilize them without having to replicate
the content directly</li>
</ul>
<li>testsuite/internals/base contains the
test classes that used to be within impl.
For i18n I was able to leave the entirety
of the test classes in the bases module
and simply explode it into the
target/test-classes directory of the
testsuite/internals/${container} modules
as part of the integration-test phase.</li>
<ul>
<li>To make it easier to then explode the
jar built from this module into sub
modules, the test classes and resources
actually need to be in src/main. As we
don't plan using the jar built from this
for anything other than testing it's not
an issue.<br>
</li>
</ul>
<li>container tests are only activated on
the integration-test phase and skipped on
the basic test phase</li>
<li><a href="https://github.com/seam/international/blob/develop/testsuite/README.md" target="_blank">https://github.com/seam/international/blob/develop/testsuite/README.md</a>
outlines all the proposed types of suites
that testsuite can contain. I believe an
initial first step should be to move the
existing container tests, or create some,
for the internals module. Over time we
can then look to flesh out the testsuite
with additional types such as smoke,
cluster, api, etc</li>
<li>One area that I haven't looked at yet is
code coverage given that the tests are
further spread than previously. I'm
hoping that it will be relatively easy to
amalgamate all the coverage data to
produce a single report.</li>
</ul>
Any questions about this please let me know.<br>
<br>
Ken<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
seam-dev mailing list
<a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a>
</pre>
</blockquote>
<br>
</div>
</blockquote>
</blockquote>
<br>
</div>
</blockquote>
<blockquote type="cite">
<div><span>_______________________________________________</span><br>
<span>seam-dev mailing list</span><br>
<span><a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a></span><br>
<span><a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a></span><br>
</div>
</blockquote>
</blockquote>
<br>
</div>
</blockquote>
</blockquote>
<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
seam-dev mailing list
<a href="mailto:seam-dev@lists.jboss.org" target="_blank">seam-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
seam-dev mailing list<br>
<a href="mailto:seam-dev@lists.jboss.org">seam-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/seam-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/seam-dev</a><br>
<br></blockquote></div><br>