Fantastic! Good work.<div><br></div><div>-Dan<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Marek Schmidt</b> <span dir="ltr"><<a href="mailto:reply%2Bi-1691451-c32d2a63f3bd03cabdcf4cb6a304e2d5daf15ab9@reply.github.com">reply+i-1691451-c32d2a63f3bd03cabdcf4cb6a304e2d5daf15ab9@reply.github.com</a>></span><br>
Date: Tue, Sep 20, 2011 at 16:33<br>Subject: [solder] Testsuite update 2 (#49)<br>To: Dan Allen <<a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a>><br><br><br>Yet another testsuite structure update, now even more simpler.<br>
<br>
This request includes Ken's changes (rebased) which brings non-arquillian unit tests back into impl/<br>
<br>
Working Weld Embedded (default) and AS7 profiles (with one test failure, which I consider a bug in Solder and/or AS7)<br>
<br>
This patch also removes the hacky MavenArtifactResolver and uses a hard-coded paths, such as ../impl/target/solder-impl.jar to ZipImport Solder Modules. I believe this is now the most robust method for importing artifacts from the same project, for which MavenDependencyResolver cannot be used. That is, until the MavenImporter is ready (which should be Real Soon Now, see SHRINKWRAP-325). The only downside of this is that <finalName/> has been added to solder POMs, so that the build outputs have a reliable file name.<br>
<br>
You can merge this Pull Request by running:<br>
<br>
git pull <a href="https://github.com/maschmid/solder" target="_blank">https://github.com/maschmid/solder</a> testsuite-update-2<br>
<br>
Or you can view, comment on it, or merge it online at:<br>
<br>
<a href="https://github.com/seam/solder/pull/49" target="_blank">https://github.com/seam/solder/pull/49</a><br>
<br>
-- Commit Summary --<br>
<br>
* yet another testsuite structure<br>
* rebase Ken's testsuite updates, moved unit tests back to impl/<br>
<br></div>-- <br><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><div><a href="http://www.google.com/profiles/dan.j.allen#about" target="_blank">http://www.google.com/profiles/dan.j.allen#about</a><br>
<a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br><a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br></div><br>
</div>