[jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1144) Make org.jboss.seam.util.Transactions a seam component

[Michael Youngstrom (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBSEAM-1144?page=all ]

Michael Youngstrom updated JBSEAM-1144:
---------------------------------------

    Attachment: seam-tx.patch

Even though I haven't received any feedback on this feature request yet I had some spare time and created a first stab anyway.

I created a Seam component that implements UserTransaction and encapsulates the JTA+EJBContext transaction logic that was previously in util.Transactions.  I then cleaned up util.Transactions so it's static methods simply call through to the SeamUserTransaction. (TODO I temporarily removed the special Glassfish transaction code.  This will need to go back into SeamUserTransaction).

In SeamPhaseListener I shifted around where transactions were committed and rolled back to take place after a request is started and before a request is ended.

In ExceptionFilter I moved the transaction cleanup into endWebRequestAfterException and enhanced ExceptionFilter so that anytime a request doesn't end correctly (reach the filter with the ApplicationContext threadlocal still available) I call endWebRequestAfterException to clean up any orphaned transactions and to try to clear out the Contexts but only do the exception handling if an exception was actually caught by the filter.

The Booking example appears to work great.  Next up I'm going to try to create an EntityManager implementation of SeamUserTransaction.

Mike

> Make org.jboss.seam.util.Transactions a seam component
> ------------------------------------------------------
>
>                 Key: JBSEAM-1144
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1144
>             Project: JBoss Seam
>          Issue Type: Feature Request
>          Components: Core
>    Affects Versions: 1.2.1.GA
>            Reporter: Michael Youngstrom
>             Fix For: 1.3.0.BETA1
>
>         Attachments: seam-tx.patch
>
>
> I know this is probably a loaded issue but please hear me out. :)  It would be nice if org.jboss.seam.util.Transactions was replaced with a Seam Component just like everything else in Seam.  This would allow for pluggable Transaction Management providers and pave the way for support for Spring Managed Transactions, JPA Local Transactions, and true Hibernate Local Transactions.  This will allow Seam applications to run without a dependency on microcontainer in tomcat and allow for tighter Framework integration with spring and others.
> I would personally be more than willing to do the work of making the an initial JTATransaction component(s) as a replacement for org.jboss.seam.util.Transactions and would also create a SpringTransaction component as a proof of concept for extending the Transaction component.
> One problem I can see off hand is we may have to interact with a transaction in some places where a Seam ApplicationContext is not available.  However, I wonder if confining Seam transactions to a seam call might help simplify matters anyway?  For example transaction cleanup could take place in the @Destroy of the transaction component instead of in the ExceptionFilter?
> Also, this wouldn't be looked at as a JTA replacement but rather a service abstraction.  Just like any other java webapp if you're using enterprise services such as EJBs or JCA JTA would be required.  if you're running on tomcat or some other simple web container a resource local transaction manager (Spring's abstraction, JPA's, or Hibernate's) can be used.
> I'm sure there are tons of other problems I'm not looking at but worst case scenario this issue would be a great place to document them and to refer rejected feature requests. (for example JBSEAM-1118)
> What do you think?
> Mike

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira