[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1821) util.Work class does not properly handle java.lang.Errors when they are thrown

[Gavin King (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBSEAM-1821?page=all ]

Gavin King closed JBSEAM-1821.
------------------------------

    Resolution: Rejected

No, that's not a good practice, IMO.

> util.Work class does not properly handle java.lang.Errors when they are thrown
> ------------------------------------------------------------------------------
>
>                 Key: JBSEAM-1821
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-1821
>             Project: JBoss Seam
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0.BETA1
>            Reporter: Chris Rudd
>
> The util.Work class that manages transactions does not properly handle the case where a java.lang.Error is thrown. 
> When a java.lang.Error is thrown the transaction is not properly cleaned up, due to the catch block only catching Exceptions. Please add the following additional catch block :
> Work.javal line 55
> catch( Error e )
> {
>    if( begin )
>    {
>       log.debug("rolling back transaction");
>       userTransaction.rollback();
>    }
>    throw e;
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira