[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2185) s:selectItems performance issue with many combo-box items

[Stephan Bublava (JIRA)]

s:selectItems performance issue with many combo-box items
---------------------------------------------------------

                 Key: JBSEAM-2185
                 URL: http://jira.jboss.com/jira/browse/JBSEAM-2185
             Project: JBoss Seam
          Issue Type: Bug
          Components: JSF
    Affects Versions: 2.0.0.CR3
            Reporter: Stephan Bublava
            Priority: Minor


UISelectItems.asSelectItems() iterates over all combo box items and calls getLabel() and getDisabled() (usually value expressions) twice per entry:

for (Object o : iterable)
{
    initVar(o);
    selectItems.add(new javax.faces.model.SelectItem(o, getLabel() == null ? null : getLabel(), "", getDisabled() == null ? false : getDisabled()));
    destroyVar();
}

Using local variables can make a noticeable difference, if there are many combo box items.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira