[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3448) MultipartFilter does not begin parsing until after transaction is started

[he youlin (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBSEAM-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12442742#action_12442742 ] 

he youlin commented on JBSEAM-3448:
-----------------------------------

this fix will cause MOTM can't wok. i change code to:
MultipartRequest multipartRequest = new MultipartRequestImpl(httpRequest, createTempFiles, 
               maxRequestSize); 
         
         // Force the request to be parsed now
         if(httpRequest.getHeader("soapaction")==null)
             multipartRequest.getParameterNames();
         
         chain.doFilter(multipartRequest, response);

and it work.

> MultipartFilter does not begin parsing until after transaction is started
> -------------------------------------------------------------------------
>
>                 Key: JBSEAM-3448
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3448
>             Project: Seam
>          Issue Type: Bug
>            Reporter: Clint Popetz
>            Assignee: Shane Bryzak
>             Fix For: 2.1.0.CR1
>
>
> Currently the multipart filter creates the request wrapper upon detecting a multipart post, but does not actually begin processing until the first time someone asks it for a parameter.  This means that upon such a POST, multipart processing won't begin until after the transaction has been created by the SeamPhaseListener, and thus for large uploads (and/or slow network connections) it's very easy to exceed the transaction timeout, leading to failed uploads.
> I think that MultipartFilter should call getParam("") before invoking the rest of the chain so that the upload/parsing happen before the tx is created.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira