[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2946) Distribution jar file different than those build via source included with dist.

Norman Richards (JIRA) jira-events at lists.jboss.org
Wed May 7 19:21:30 EDT 2008


    [ http://jira.jboss.com/jira/browse/JBSEAM-2946?page=comments#action_12412083 ] 
            
Norman Richards commented on JBSEAM-2946:
-----------------------------------------

The reason for the difference is that the initcore target copies resource from src to classes, but the txt file isn't created until the antlr task runs later.  (I don't believe we can change the ordering here)  So, the first time through txt file isn't copied (because antlr hasn't generated it), but it is there on later passes and is copies.  (note that clean does not clean the antlr-generated files)  

That file isn't needed at runtime, so it really doesn't matter if it is there or not.  For completeness, I've changed the build so that it renames the file to something that won't get automatically picked up.  The other alternative was to delete it, but I thought perhaps it might be useful for debugging so it's better to leave it around than just automatically delete it.  

We might want to sort out the build for 2.1 because I noticed antlr now generates .smap files which we might actually want to go in the jar to aid in debugging.  I don't know how useful it would be, or even if it actually works.  But, if we do want those included then we should sort out the build steps here.

> Distribution jar file different than those build via source included with dist.
> -------------------------------------------------------------------------------
>
>                 Key: JBSEAM-2946
>                 URL: http://jira.jboss.com/jira/browse/JBSEAM-2946
>             Project: Seam
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.0.2.CR2
>            Reporter: Jay Balunas
>         Assigned To: Norman Richards
>            Priority: Minor
>             Fix For: 2.0.2.GA
>
>
> Created a dist from a pristine svn checkout and with a clean local maven repo.  Saved off the seam jars that are included in dist.  Then built the dist via "ant" command.  Extracted both the orig jars and the new jars and compared.
> "org/jboss/seam/text/SeamTextParserTokenTypes.txt" is not in the original "jboss-seam.jar" .  The newly built "jboss-seam.jar" does contain the file.  
> After talking with Pete he does not believe this is a vital file and so I have marked it as "minor"

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the seam-issues mailing list