[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3681) WTF code in RuleBasedPermissionResolver

egor kolesnikov (JIRA) jira-events at lists.jboss.org
Fri Nov 7 04:56:36 EST 2008


WTF code in RuleBasedPermissionResolver
---------------------------------------

                 Key: JBSEAM-3681
                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3681
             Project: Seam
          Issue Type: Bug
          Components: Security
    Affects Versions: 2.1.0.SP1
            Reporter: egor kolesnikov


We've got some lulz reading this today:

public class RuleBasedPermissionResolver implements PermissionResolver, Serializable

//skipped

   private void synchronizeContext()
   {
      Identity identity = Identity.instance();
      
      getSecurityContext().insert(identity.getPrincipal()); 
      
      if (getSecurityContext() != null) // just a BRILLIANT check after calling insert() on the previous line
      {
       //skipped
      }
   }
}

Please fix this "professional open source" code in the next version :)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the seam-issues mailing list