[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3724) Wicket NoConversationPage is often ignored

[Pete Muir (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBSEAM-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12438873#action_12438873 ] 

Pete Muir commented on JBSEAM-3724:
-----------------------------------

(b) is a no-no, and I prefer (a) over (c)

> Wicket NoConversationPage is often ignored
> ------------------------------------------
>
>                 Key: JBSEAM-3724
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3724
>             Project: Seam
>          Issue Type: Bug
>          Components: Wicket
>            Reporter: Clint Popetz
>            Assignee: Clint Popetz
>
> The SeamComponentInstantiationListener will only be invoked when a page/component is first created, which is not the case when back-buttoning into a form that you already submitted, for example.  So we're able to back-button into dead conversations.  To make sure NoConversationPage is respected we do one of the following:
>  
> (a) throw the AbortException() in the ConversationInterceptor 
> (b) make user pages derive from a SeamWebPage, and override onPageAttached() to check for the annotation/conversation
> (c) when instrumenting, if a component is a page subclass, add a synthetic onPageAttached() to do (b) if it doesn't exist, or supplement any existing one.
> I prefer (a) because it means a seam-instrumented wicket component will never be called outside a long running conversation if NoConversationId is set, regardless of how the wicket request cycle api changes.  
> Pete, any thoughts?  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira