[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3698) Error during rendering of an EMail in an event listener causes failure in rendering of next page

[Marko Strukelj (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBSEAM-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12464809#action_12464809 ] 

Marko Strukelj commented on JBSEAM-3698:
----------------------------------------


Mark: can you please change ui/src/main/java/org/jboss/seam/ui/facelet/RendererRequest.java in Seam 2.1.2.CR2 from:

101 	      try {
102 	          init();
103 	          renderFacelet(facesContext, faceletForViewId(viewId));
104 	          cleanup();
105 	      } finally {
106 	          resetContextClassLoader();
107 	      }      

to:


101 	      try {
102 	          init();
103 	          renderFacelet(facesContext, faceletForViewId(viewId));
104 	      } finally {
105 	          resetContextClassLoader();
106 	          cleanup();
107 	      }      


Recompile, give it a try, and report if it solves your problem ...

Tomaz, and I, when putting together a patch for JBSEAM-3555, weren't quite sure how to handle cleanup(). Maybe there is a reason it isn't inside a finally block - maybe it is not supposed to be executed in case of an exception... To avoid introducing any unexpected behaviour together with a fix we just left everything the way it was and just inserted some additional code in appropriate places.



> Error during rendering of an EMail in an event listener causes failure in rendering of next page
> ------------------------------------------------------------------------------------------------
>
>                 Key: JBSEAM-3698
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-3698
>             Project: Seam
>          Issue Type: Bug
>          Components: Mail
>    Affects Versions: 2.1.0.SP1
>         Environment: Windows XP, Java 6, 2GB RAM, JBoss 4.2.2.GA
>            Reporter: Wayne Bagguley
>             Fix For: 2.1.2.CR2
>
>         Attachments: RendererRequest.diff
>
>
> I have a method that is defined as a listener like this :
> @Observer(JpaIdentityStore.EVENT_USER_CREATED)
> This attempts to send an email to the user when he registers but if the email rendering fails for some reason the exception is caught and the method returns normally. However, instead of the next page being rendered, the original page gets rendered incorrectly, with parts of the form in the wrong place. The failure of rendering the EMail should not affect the progress of the rendering of the next page if the exception is caught.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira