[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2697) Add attribute to s:link tag to make creation of magic dataModelSelection URL parameter optional
Mauricio Seeberger (JIRA)
jira-events at lists.jboss.org
Mon Aug 17 12:03:26 EDT 2009
[ https://jira.jboss.org/jira/browse/JBSEAM-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12481206#action_12481206 ]
Mauricio Seeberger commented on JBSEAM-2697:
--------------------------------------------
Recently I had the same problem. The simplest solution is adding an
<f:param name="dataModelSelection" />
as _first_ parameter inside your s:link to prevent the dataModelSelection being rendered. It works in Seam 2.1.1.GA.
> Add attribute to s:link tag to make creation of magic dataModelSelection URL parameter optional
> -----------------------------------------------------------------------------------------------
>
> Key: JBSEAM-2697
> URL: https://jira.jboss.org/jira/browse/JBSEAM-2697
> Project: Seam
> Issue Type: Feature Request
> Components: JSF Controls
> Affects Versions: 2.0.1.GA
> Reporter: Wolfgang Schwendt
> Priority: Minor
> Attachments: JBSEAM-2697-patch-20081023.txt
>
>
> When an s:link component (org.jboss.seam.ui.component.UILink) is placed into a h:dataTable backed by a javax.faces.model.DataModel, the s:link automatically generates the magic token for the magic "dataModelSelection" parameter regardless of whether the latter is really needed or not.
>
> This can generate ugly URLs. The following example is particulary ugly:
> http://127.0.0.1:8080/seminaris/seminarDetails.seam?seminarId=2&dataModelSelection=sem%3AzumSeminarAnmelden_szSeminarSuchen_seminarListeDataModel%5B1%5D&actionMethod=zumSeminarAnmelden%2FseminarSuchen.xhtml%3AzumSeminarAnmelden_seminarBuchenAction.selectSeminar
> Without the "dataModelSelection" parameter, the URL would look much cleaner:
> http://127.0.0.1:8080/seminaris/seminarDetails.seam?semId=2
> So my question: Couldn't we make the "dataModelSelection" parameter optional? (For example, by adding an attribute to the s:link tag).
> Btw: I'm aware that org.jboss.seam.ui.component.UISeamCommandBase.getUrl() is the culprit that triggers inclusion of the the dataModelSelection parameter, so I know how to remove the dataModelSelection parameter generation, but it would be nice if also the officially released Seam version allowed the deactivation of the magic token generation.
> Further, no magic token is generated if a UIDataTable is supplied by a normal List rather than a DataModel (cf. UISeamCommandBase.getSelection() ), but unfortunately there can be cases where it makes sense to supply the table data as DataModel rather than normal List.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the seam-issues
mailing list