[seam-issues] [JBoss JIRA] Closed: (JBSEAM-4334) Useless lock in Initialization.redeploy

Tue Jan 26 07:14:19 EST 2010

     [ https://jira.jboss.org/jira/browse/JBSEAM-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marek Novotny closed JBSEAM-4334.
---------------------------------

    Resolution: Done


removed the locking

> Useless lock in Initialization.redeploy
> ---------------------------------------
>
>                 Key: JBSEAM-4334
>                 URL: https://jira.jboss.org/jira/browse/JBSEAM-4334
>             Project: Seam
>          Issue Type: Bug
>          Components: Core
>            Reporter: Stuart Douglas
>            Assignee: Norman Richards
>             Fix For: 2.2.1.CR1
>
>
>  Initialization.redeploy has the following bit of code:
> ReentrantLock lock = new ReentrantLock();
> if (lock.tryLock(500, TimeUnit.MILLISECONDS))
> This lock does not provide any level of protection, as every thread creates a new lock and then locks it. This will only cause potential problems in debug mode.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira