[seam-issues] [JBoss JIRA] Commented: (SEAMSOCIAL-14) Avoid using an Enum to qualify services

[Antoine Sabot-Durand (JIRA)]

    [ https://issues.jboss.org/browse/SEAMSOCIAL-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610159#comment-12610159 ] 

Antoine Sabot-Durand commented on SEAMSOCIAL-14:
------------------------------------------------

After think for it more deeply, I went back to @relatedTo qualifier with a String Value and not an Enum Value.
The extension check RelatedTo Annotation on OAuthService bean to find all existing value for @RelatedTo value. Thus if someone add a new Social network it will taken into account automatically when the @RelatedTo(<value>) qualifier is added to the bean.

> Avoid using an Enum to qualify services
> ---------------------------------------
>
>                 Key: SEAMSOCIAL-14
>                 URL: https://issues.jboss.org/browse/SEAMSOCIAL-14
>             Project: Seam Social
>          Issue Type: Enhancement
>          Components: OAuth Core
>            Reporter: Antoine Sabot-Durand
>            Assignee: Antoine Sabot-Durand
>   Original Estimate: 3 days
>  Remaining Estimate: 3 days
>
> Today the @RelatedTo qualifier use an Enum type to choose the right service (i.e @RelatedTo(Service.Twitter)). This solution is too closed and could be a problem if someone need to extend the framework by adding a new Service since one need to add a value in the Service Enum type...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira