[seam-issues] [JBoss JIRA] Commented: (SEAMFACES-133) UIInputContainer should accept ValueExpression for the label attribute.

[Alt Avatar (JIRA)]

    [ https://issues.jboss.org/browse/SEAMFACES-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605141#comment-12605141 ] 

Alt Avatar commented on SEAMFACES-133:
--------------------------------------

Also, labelHasEmptyValue() should handle the case of there being no label at all. Currently, it will fail with a NPE.

I was also getting cases were labelValue in the same method would be null. I fixed both issues by replacing the body of UIInputContainer.java#labelHasEmptyValue() with:

    	HtmlOutputLabel label = elements.getLabel();
        if (label==null) 
        	return false;
	Object labelValue = label.getValue();
        if (labelValue==null)
        	return false;
	return (labelValue.toString().trim().equals(":") || labelValue.toString()
                .trim().equals(""));

> UIInputContainer should accept ValueExpression for the label attribute.
> -----------------------------------------------------------------------
>
>                 Key: SEAMFACES-133
>                 URL: https://issues.jboss.org/browse/SEAMFACES-133
>             Project: Seam Faces
>          Issue Type: Bug
>          Components: UI Components
>    Affects Versions: 3.0.0.Final
>         Environment: Ubuntu 10.10 64bit, JBoss 6
>            Reporter: Alt Avatar
>            Assignee: José Freitas
>             Fix For: 3.0.2
>
>
> UIInputContainer should evaluate ValueExpressions for the "label" attribute. This is especially useful for internationalization, where the component could be included as: <x:inputcontainer label="#{msg.foo}/><h:inputText...
> Currently, ValueExpressions are ignored and only String literals work.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira