<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3b4d64" style="background-color:#3b4d64;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://issues.jboss.org/s/en_US-g3yjjf/733/58/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://community.jboss.org/people/maschmid/avatar/16.png" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="maschmid" id="email_maschmid" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=maschmid" style="color:#003366;">Marek Schmidt</a>
reopened <img src="https://issues.jboss.org/images/icons/improvement.gif" height="16" width="16" border="0" align="absmiddle" alt="Patch"> <a style='color:#003366;text-decoration:none;' href='https://issues.jboss.org/browse/JBSEAM-4861'>JBSEAM-4861</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#003366;text-decoration:none;' href='https://issues.jboss.org/browse/JBSEAM-4861'><strong>Component.java uses application wide factoryLock too often </strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>The patch introduces a potential deadlock with components using each other factories, such as in the following sample: </p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">@Scope(ScopeType.APPLICATION)
@Name(<span class="code-quote">"factoryLock.knitFactory"</span>)
<span class="code-keyword">public</span> <span class="code-keyword">static</span> class KnitFactory
{
@Factory(value=<span class="code-quote">"factoryLock.knitPurl"</span>, scope=ScopeType.SESSION)
<span class="code-keyword">public</span> <span class="code-object">String</span> getDoubleKnit() {
<span class="code-keyword">return</span> <span class="code-quote">"knit("</span> + (<span class="code-object">String</span>)Component.getInstance(<span class="code-quote">"factoryLock.purl"</span>) + <span class="code-quote">")"</span>;
}
@Factory(value=<span class="code-quote">"factoryLock.knit"</span>, scope=ScopeType.SESSION)
<span class="code-keyword">public</span> <span class="code-object">String</span> getKnit() {
<span class="code-keyword">return</span> <span class="code-quote">"knit"</span>;
}
}
@Scope(ScopeType.APPLICATION)
@Name(<span class="code-quote">"factoryLock.purlFactory"</span>)
<span class="code-keyword">public</span> <span class="code-keyword">static</span> class PurlFactory
{
@Factory(value=<span class="code-quote">"factoryLock.purlKnit"</span>, scope=ScopeType.SESSION)
<span class="code-keyword">public</span> <span class="code-object">String</span> getDoublePurl() {
<span class="code-keyword">return</span> <span class="code-quote">"purl("</span> + (<span class="code-object">String</span>)Component.getInstance(<span class="code-quote">"factoryLock.knit"</span>) + <span class="code-quote">")"</span>;
}
@Factory(value=<span class="code-quote">"factoryLock.purl"</span>, scope=ScopeType.SESSION)
<span class="code-keyword">public</span> <span class="code-object">String</span> getPurl() {
<span class="code-keyword">return</span> <span class="code-quote">"purl"</span>;
}
}</pre>
</div></div>
<p>this may cause a deadlock if two different requests in the same session ask for #{factoryLock.knitPurl} and #{factoryLock.purlKnit} respectively.</p>
<p>The problem is that different threads may lock the components in different order.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="maschmid" id="email_maschmid" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=maschmid" style="color:#003366;">Marek Schmidt</a>
(03/Jul/12 7:39 AM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Resolution:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Done</span>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Status:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Resolved</span>
<span class="diffaddedchars" style="background-color:#ddfade;">Reopened</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#003366;' href='https://issues.jboss.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#003366;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->