[security-dev] common module in picketlink

Marek Posolda mposolda at redhat.com
Thu Jan 31 05:26:52 EST 2013


Thanks Anil!

I've just sent PR https://github.com/picketlink/picketlink/pull/44 with 
minor change for removing my reflection hack from PicketlinkConfigParser 
as it's not needed anymore with your changes.

Regards,
Marek

On 30/01/13 23:40, Anil Saldhana wrote:
> Marek,
>     I moved the config types and config parsers from the federation
> module into config.
>
> Regards,
> Anil
>
> On 01/28/2013 12:23 PM, Anil Saldhana wrote:
>> I have created the common module.
>>
>> On 01/28/2013 05:03 AM, Marek Posolda wrote:
>>> Thanks Anil, I don't have any objections. Let me know if you want some
>>> help from me.
>>>
>>> Marek
>>>
>>> On 24/01/13 15:56, Anil Saldhana wrote:
>>>> Marek,
>>>>        I do not think I have any objections.  I will create the common
>>>> module on Monday and do a bunch of "git mv" to start the common module
>>>> going.
>>>>
>>>> If there are any objections/feedback, we have until Monday.
>>>>
>>>> Regards,
>>>> Anil
>>>>
>>>> On 01/18/2013 11:09 AM, Marek Posolda wrote:
>>>>> I mentioned yesterday that it may be good to have something like
>>>>> separate "common" module, which will contain some stuff and
>>>>> functionalities, which may be needed across all other picketlink modules.
>>>>>
>>>>> Example of such things could be:
>>>>> - Class StringUtil from federation module (Some stuff in this class is
>>>>> specific to federation, but some common methods like
>>>>> StringUtil.isNotNull, StringUtil.getSystemPropertyAsString etc. are
>>>>> useful in other modules as well)
>>>>> - Probably some other util classes in federation
>>>>> - Some parts of logging
>>>>> - Reflection and properties helper classes from IDM module
>>>>> - Base64 util class (Currently we have same class forked two times in
>>>>> picketlink project. Once in "federation" module and once in "idm" module)
>>>>> - Probably some more...
>>>>>
>>>>> wdyt?
>>>>> Marek
>>>>>
> _______________________________________________
> security-dev mailing list
> security-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/security-dev



More information about the security-dev mailing list