<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Thanks for your kind comments towards this design decision :) <div><br></div><div>Just curious - in 1.x I made it partly to have single instance of IdentityStore reused in different context/realm - so purely stateless design. Do you plan the same way or still handle some state in single IdentityStore instance?</div><div><br><div><div>On Oct 25, 2012, at 5:33 AM, Shane Bryzak <<a href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
<div bgcolor="#FFFFFF" text="#000000">
Just to add to the previous changes, I've also made a change to the
IdentityStore API so that each method includes an
IdentityStoreInvocationContext parameter. This API was first
introduced by Bolek in PicketLink 1.x [1] and offers a robust method
of passing context-specific state to individual IdentityStore
invocations. <br>
<br>
I can't think of any more elegant design that addresses this
requirement or improves on the work Bolek has already done, so
beyond any minor tweaks to the API I think we should stick with the
motto "if it ain't broke, don't fix it". <br>
<br>
I've gone ahead and updated both (JPA and LDAP) IdentityStore
implementations to include these parameters. Along the way though,
it seems I've broken a couple of the LDAP tests; Pedro or Anil,
could you please take a look at these as my LDAP is a little rusty -
I've attached the stack trace output from the test run.<br>
<br>
[1]
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="https://github.com/picketlink/picketlink-idm/tree/1.4/picketlink-idm-spi/src/main/java/org/picketlink/idm/spi/store">https://github.com/picketlink/picketlink-idm/tree/1.4/picketlink-idm-spi/src/main/java/org/picketlink/idm/spi/store</a>
</div>
<span><org.picketlink.test.idm.internal.mgr.DefaultLDAPIdentityManagerTestCase.txt></span>_______________________________________________<br>security-dev mailing list<br><a href="mailto:security-dev@lists.jboss.org">security-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/security-dev<br></blockquote></div><br></div></body></html>