<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 10/29/2012 05:22 AM, Boleslaw
      Dawidowicz wrote:<br>
    </div>
    <blockquote
      cite="mid:4288A292-D239-40DA-A0CE-711D0DC930CD@redhat.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html;
        charset=ISO-8859-1">
      Thanks for your kind comments towards this design decision :)&nbsp;
      <div><br>
      </div>
      <div>Just curious - in 1.x I made it partly to have single
        instance of IdentityStore reused in different context/realm - so
        purely stateless design. Do you plan the same way or still
        handle some state in single IdentityStore instance?</div>
    </blockquote>
    <br>
    Exactly the same way, except for the IdentityStore configuration
    itself.&nbsp; We'll also use the invocation context to provide the event
    SPI, acting as a bridge to allow the IdentityStore to raise events
    for multiple environment types.<br>
    <br>
    <blockquote
      cite="mid:4288A292-D239-40DA-A0CE-711D0DC930CD@redhat.com"
      type="cite">
      <div><br>
        <div>
          <div>On Oct 25, 2012, at 5:33 AM, Shane Bryzak &lt;<a
              moz-do-not-send="true" href="mailto:sbryzak@redhat.com">sbryzak@redhat.com</a>&gt;
            wrote:</div>
          <br class="Apple-interchange-newline">
          <blockquote type="cite">
            <meta http-equiv="content-type" content="text/html;
              charset=ISO-8859-1">
            <div bgcolor="#FFFFFF" text="#000000"> Just to add to the
              previous changes, I've also made a change to the
              IdentityStore API so that each method includes an
              IdentityStoreInvocationContext parameter.&nbsp; This API was
              first introduced by Bolek in PicketLink 1.x [1] and offers
              a robust method of passing context-specific state to
              individual IdentityStore invocations.&nbsp; <br>
              <br>
              I can't think of any more elegant design that addresses
              this requirement or improves on the work Bolek has already
              done, so beyond any minor tweaks to the API I think we
              should stick with the motto "if it ain't broke, don't fix
              it".&nbsp; <br>
              <br>
              I've gone ahead and updated both (JPA and LDAP)
              IdentityStore implementations to include these
              parameters.&nbsp; Along the way though, it seems I've broken a
              couple of the LDAP tests; Pedro or Anil, could you please
              take a look at these as my LDAP is a little rusty - I've
              attached the stack trace output from the test run.<br>
              <br>
              [1]
              <meta http-equiv="content-type" content="text/html;
                charset=ISO-8859-1">
              <a moz-do-not-send="true"
href="https://github.com/picketlink/picketlink-idm/tree/1.4/picketlink-idm-spi/src/main/java/org/picketlink/idm/spi/store">https://github.com/picketlink/picketlink-idm/tree/1.4/picketlink-idm-spi/src/main/java/org/picketlink/idm/spi/store</a>
            </div>
            <span>&lt;org.picketlink.test.idm.internal.mgr.DefaultLDAPIdentityManagerTestCase.txt&gt;</span>_______________________________________________<br>
            security-dev mailing list<br>
            <a moz-do-not-send="true"
              href="mailto:security-dev@lists.jboss.org">security-dev@lists.jboss.org</a><br>
            <a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/security-dev">https://lists.jboss.org/mailman/listinfo/security-dev</a><br>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </body>
</html>