[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-92) Support addition of Classes using a FQN/ClassLoader

[Aslak (JIRA)]

    [ https://jira.jboss.org/jira/browse/SHRINKWRAP-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12497845#action_12497845 ] 

Aslak commented on SHRINKWRAP-92:
---------------------------------

Why default to TCCL if ClassLoader arg is null ?

I think it would be better to have two methods:

addClass(fqn)  <- defaults to tccl
addClass(fqn, ClassLoader) <-- illegalargumentexception if classloader == null



> Support addition of Classes using a FQN/ClassLoader
> ---------------------------------------------------
>
>                 Key: SHRINKWRAP-92
>                 URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-92
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: api, impl-base
>            Reporter: Andrew Lee Rubinger
>            Assignee: Andrew Lee Rubinger
>             Fix For: 1.0.0-alpha-3
>
>
> The following syntax:
> archive.addClass(MyClass.class);
> ...requires that the running CL has "MyClass" visible to it.  This may not always be the case.  Take for instance a test of EJB3 beans; the test class may not be able to load the EJB3 Bean Implementation class, as this may leak other internals out.  The test only needs the interface in able to test it, though it'd still like to package up the impl class.
> Support:
> archive.addClass(String fqn, ClassLoader cl)
> ...where the archive implementation may then use the specified CL to load the class of the specified name

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira