[shrinkwrap-issues] [JBoss JIRA] Created: (SHRINKWRAP-91) Support for Add Filters on 'multi' add methods

Aslak (JIRA) jira-events at lists.jboss.org
Wed Nov 25 06:03:29 EST 2009


Support for Add Filters on 'multi' add methods
----------------------------------------------

                 Key: SHRINKWRAP-91
                 URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-91
             Project: ShrinkWrap
          Issue Type: Feature Request
            Reporter: Aslak


When assembling Archives using methods like:
 archive.add(archive)
 archive.addPackages(true, Package.getPackage("org.junit"))

it would be useful to have some sort of 'AcceptFilter' to minimize the work. 

Usecase -1:
you want to add Package org.junit but NOT junit.org.runners.model. The way it works now is you have to add every single package 'around' the one you want don't want. This can be a pretty big list.

Usecase-2:
You want to merge two archives, but use your own descriptors..

Possible impl.. 
{code}
interface Filter<T> {
  boolean accept(T obj);
}

    addPackage(Boolean recursive, Filter<Class<?>> filter, Package... packs) 
    {
      for(Class<?> class : package) 
      {
         if(filter.accept(class)) 
         {
            addClass(class);
         }
      }
    }
{code}

This way we could create archives like:

{code}

  archive.addPackage(
                 true, 
                new RegExpExcludeFilter(".*/models/.*"), 
               Package.getPackage("org.junit")
  )  

  archive.add(
               otherArchive,
               new RegExpIncludeFilter("/META-INF/*")
  )  

{code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the shrinkwrap-issues mailing list