[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-61) Switch order of "path" and "source" in Archive.merge

[Jesper Pedersen (JIRA)]

    [ https://jira.jboss.org/jira/browse/SHRINKWRAP-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12490785#action_12490785 ] 

Jesper Pedersen commented on SHRINKWRAP-61:
-------------------------------------------

Other examples include:

org.jboss.shrinkwrap.api.container.ResourceContainer
- addResource(String)
- addResource(File)

org.jboss.shrinkwrap.api.container.EnterpriseContainer
- addApplicationResource(String)
- addApplicationResource(File)
- addModule(Archive)
- addModule(String)
- addModule(File)

org.jboss.shrinkwrap.api.container.WebContainer
- addWebResource(String)
- addWebResource(File)

org.jboss.shrinkwrap.api.container.ManifestContainer 
- addManifestResource(String)
- addManifestResource(File)

Maybe adding a common suffix to each of the above methods to solve the problem

> Switch order of "path" and "source" in Archive.merge
> ----------------------------------------------------
>
>                 Key: SHRINKWRAP-61
>                 URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-61
>             Project: ShrinkWrap
>          Issue Type: Task
>          Components: api, impl-base
>            Reporter: Andrew Lee Rubinger
>
> Switch:
> T merge(Path path, Archive<?> source) throws IllegalArgumentException;
> ...to:
> T merge(Archive<?> source, Path path) throws IllegalArgumentException;
> ...to match:
> T merge(Archive<?> source) throws IllegalArgumentException;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira