[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-112) Create a Unified Importer API

[Andrew Lee Rubinger (JIRA)]

    [ https://jira.jboss.org/jira/browse/SHRINKWRAP-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12501880#action_12501880 ] 

Andrew Lee Rubinger commented on SHRINKWRAP-112:
------------------------------------------------

Let's discuss on forum: 

Why interpret String as new File() ?
Why assume a URL is local and can be represented as a File?

In an attempt to add user-friendly hooks I fear we become too opinionated at best and unpredictable at worst.

> Create a Unified Importer API
> -----------------------------
>
>                 Key: SHRINKWRAP-112
>                 URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-112
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>            Reporter: Aslak Knutsen
>            Assignee: Aslak Knutsen
>
> Importer	
> 	from(String)
> 		from(new File(String)) 
> 	from(File)
> 		File.isFile -> LookupImporterType -> ZipImporter
> 		File.isDirectory -> ExplodedImporter
> 	from(URL)
> 		URL.getFile.isDirectory -> ExplodedImporter
> 		URL.getExtension -> LookupImporterType -> ZipImporter

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira