[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-116) OOM Exception when exporting large archives using ZIPExporter

[Andrew Lee Rubinger (JIRA)]

    [ https://jira.jboss.org/jira/browse/SHRINKWRAP-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12506735#action_12506735 ] 

Andrew Lee Rubinger commented on SHRINKWRAP-116:
------------------------------------------------

The issue isn't that we're returning an InputStream; it's that we're backing it with a byte array and thus keeping the full contents in memory.  Instead we can switch to a pull model.  @see linked forum discussion for implications.

> OOM Exception when exporting large archives using ZIPExporter
> -------------------------------------------------------------
>
>                 Key: SHRINKWRAP-116
>                 URL: https://jira.jboss.org/jira/browse/SHRINKWRAP-116
>             Project: ShrinkWrap
>          Issue Type: Bug
>          Components: impl-base
>            Reporter: Aslak Knutsen
>
> The ZIPExporter writes to a ZipOutputStream backed by a ByteArrayOutputStream. The content is later returned as a ByteArrayInputStream.
> This does not work well for larger archives.
> The API should be switched:
>  - do not return a inputstream
>  - write directly to given outputstream 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira