[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-202) Should be able to refer to a Empty StringAsset

Andrew Lee Rubinger (JIRA) jira-events at lists.jboss.org
Thu Jul 8 11:42:46 EDT 2010


    [ https://jira.jboss.org/browse/SHRINKWRAP-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12538436#action_12538436 ] 

Andrew Lee Rubinger commented on SHRINKWRAP-202:
------------------------------------------------

Empty content isn't just String-based.  Why not use: http://docs.jboss.org/shrinkwrap/1.0.0-alpha-10/org/jboss/shrinkwrap/api/asset/EmptyAsset.html ?

> Should be able to refer to a Empty StringAsset
> ----------------------------------------------
>
>                 Key: SHRINKWRAP-202
>                 URL: https://jira.jboss.org/browse/SHRINKWRAP-202
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: api
>    Affects Versions: 1.0.0-alpha-10
>            Reporter: Aslak Knutsen
>            Priority: Minor
>
> To help show intent we could create a public static final instance on StringAsset called EMPTY. 
> public class StringAsset implements Asset {
>  public static final Asset EMPTY = new StringAsset("");
>  ...
> }
> so instead of writing:
> archive.add(new StringAsset(""), "beans.xml")
> we can write a more descriptive:
> archive.add(StringAsset.EMPTY, "beans.xml")
> EMPTY, NO_CONTENT, EMPTY_CONTENT ??

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the shrinkwrap-issues mailing list