[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-240) addServiceProvider should add class to archive

[Aslak Knutsen (JIRA)]

    [ https://jira.jboss.org/browse/SHRINKWRAP-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562030#action_12562030 ] 

Aslak Knutsen commented on SHRINKWRAP-240:
------------------------------------------

Perhaps your right.. 

ServiceProviderContainer extends ManifestContainer, ClassContainer

> addServiceProvider should add class to archive
> ----------------------------------------------
>
>                 Key: SHRINKWRAP-240
>                 URL: https://jira.jboss.org/browse/SHRINKWRAP-240
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: api
>    Affects Versions: 1.0.0-alpha-11
>            Reporter: Dan Allen
>            Priority: Minor
>
> My intuition tells me that addServiceProvider should add the service provider classes I specify to the archive. To my surprise, it does not. I can't see any scenario in which you specify a service provider for a class that isn't in the archive. For the edge case, you could always extract it manually after the call to addServiceProvider.
> Currently:
> addClass(MyServiceImpl.class).addServiceProvider(Service.class, MyServiceImpl.class)
> Proposed:
> addServiceProvider(Service.class, MyServiceImpl.class)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira