[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKDESC-23) Web app descriptor tests fail because of carriage return

[Andrew Rubinger (JIRA)]

    [ https://jira.jboss.org/browse/SHRINKDESC-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564434#comment-12564434 ] 

Andrew Rubinger commented on SHRINKDESC-23:
-------------------------------------------

Thanks for filing, Andy.

I'd like to see a solution in place which tests this in a platform-independent way.  For instance using Readers.  Commented on:

https://github.com/shrinkwrap/descriptors/pull/7

S,
ALR

> Web app descriptor tests fail because of carriage return
> --------------------------------------------------------
>
>                 Key: SHRINKDESC-23
>                 URL: https://jira.jboss.org/browse/SHRINKDESC-23
>             Project: ShrinkWrap Descriptors
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 1.0.0-alpha-1
>         Environment: Windows, Dos, maven 3.0, JDK 1.6
>            Reporter: Andy Gibson
>
> The tests for the web app descriptors are failing because of the carriage return in the expected web.xml files in the test/resources used to compare the actual results with what it should be. The fix is to change the assert equals to 
> Assert.assertEquals(expected.toString().replace("\r",""), webApp);
> for each one to strip out the carriage returns, but leave the line feeds. I'll submit a fix for it through GitHub.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira