[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKDESC-24) Fix version problems in the persistence descriptor

Andy Gibson (JIRA) jira-events at lists.jboss.org
Sun Nov 21 03:01:54 EST 2010


    [ https://jira.jboss.org/browse/SHRINKDESC-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564459#comment-12564459 ] 

Andy Gibson commented on SHRINKDESC-24:
---------------------------------------

Created a pull request in Github.

Version now has a default value
The version attribute is exposed in the descriptor
Added 2 test cases to verify the default version appears and that it can be successfully set in the descriptor.

> Fix version problems in the persistence descriptor
> --------------------------------------------------
>
>                 Key: SHRINKDESC-24
>                 URL: https://jira.jboss.org/browse/SHRINKDESC-24
>             Project: ShrinkWrap Descriptors
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 1.0.0-alpha-1
>         Environment: Windows, Maven 3.0, JDK 1.6
>            Reporter: Andy Gibson
>
> In the PersistenceModel, the xml accessor type is set to field, but the class uses some default logic in the getter to default the version to 2.0 if null. However, since the fields are to access the version when generating the xml, it is always null unless explicitly set. It's always null since there is no way to set it as it is not implemented.
> I have a fix for it which I'll submit as a pull request through GitHub.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the shrinkwrap-issues mailing list