[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-179) Container.setXX methods should support the new Package construct

[Davide D'Alto (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593391#comment-12593391 ] 

Davide D'Alto commented on SHRINKWRAP-179:
------------------------------------------

https://github.com/DavideD/shrinkwrap/commits/SHRINKWRAP-179

> Container.setXX methods should support the new Package construct
> ----------------------------------------------------------------
>
>                 Key: SHRINKWRAP-179
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-179
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: api, impl-base
>    Affects Versions: 1.0.0-alpha-9
>            Reporter: Aslak Knutsen
>             Fix For: 1.0.0-beta-1
>
>
> We support this construct for adding, Container.addXX(Package, Name)  adds a Named resource inside a Package
> Container.setXX() methods should support the same.
> example:
>     * @param resourcePackage The package of the resource
>     * @param resourceName The name of the resource inside resoucePackage
> T addManifestResource(Package resourcePackage, String resourceName) throws IllegalArgumentException;
> T addManifestResource(Package resourcePackage, String resourceName, String target) throws IllegalArgumentException;
> T addManifestResource(Package resourcePackage, String resourceName, ArchivePath target) throws IllegalArgumentException;
> addManifestResource(org.test.MyClass.class.getPackage(), "myclass.resources") -> org/test/myclass.resources
> Set should have the same capabilities:
>    T setManifest(String resourceName) throws IllegalArgumentException;
>    T setManifest(Package resourcePackage, String resourceName) throws IllegalArgumentException;

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira