[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKDESC-54) Develop/split EE Spec and JBoss-specific descriptors in API / Impl Split

[Aslak Knutsen (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622321#comment-12622321 ] 

Aslak Knutsen commented on SHRINKDESC-54:
-----------------------------------------

Just a few comments from the latest build:

* WebApp30Descriptor vs WebAppDescriptor
We have version in the PackageName already, org.jboss.shrinkwrap.descriptor.api.webapp30

* getAllServlet() removeAllServlet() vs getAllServlets() removeAllServlets()
Since we can remove multiple, the API should reflect that in plural form

* unset distributable() 
Boolean distributable can be set and read(isDistributable), but not unset

* WebAppVersionType._3_0 vs WebAppVersionType.3_0
Why the extra underscore? And if we have one generated 'package' pr version, do we need to set the version at all ?

* Missing some xml escape in javadoc comments
See the Example: http://jboss.hudson.alrubinger.com/job/Descriptors_1.2.0-X/javadoc/org/jboss/shrinkwrap/descriptor/api/javaee6/ResourceRefType.html 



> Develop/split EE Spec and JBoss-specific descriptors in API / Impl Split
> ------------------------------------------------------------------------
>
>                 Key: SHRINKDESC-54
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-54
>             Project: ShrinkWrap Descriptors
>          Issue Type: Task
>            Reporter: Andrew Rubinger
>            Assignee: Ralf Battenfeld
>             Fix For: 1.2.0-alpha-1
>
>
> This task to track the extensive refactoring and reworking of Descriptors as done through the POC offered by Ralf Battenfeld.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira