[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKDESC-83) assertXPath ignores missing attributes

[Bartosz Majsak (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625563#comment-12625563 ] 

Bartosz Majsak commented on SHRINKDESC-83:
------------------------------------------

Messed up with github fork last time. Correct pull request is https://github.com/shrinkwrap/descriptors/pull/40

Sorry for that!

> assertXPath ignores missing attributes
> --------------------------------------
>
>                 Key: SHRINKDESC-83
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-83
>             Project: ShrinkWrap Descriptors
>          Issue Type: Sub-task
>            Reporter: Andrew Rubinger
>            Priority: Blocker
>
> Given: 
> {code}<persistence>
>   <persistence-unit name="hibernate-unit">
>     <transaction-type>JTA</transaction-type>
>     <provider>org.hibernate.ejb.HibernatePersistence</provider>
>     <jta-data-source>java:/DefaultDS</jta-data-source>
>     <class>org.jboss.shrinkwrap.descriptor.api.persistence20.PersistenceDescriptor</class>
>   </persistence-unit>
> </persistence>{code}
> ...running assertXPath like so:
> {code}assertXPath(desc, "/persistence/persistence-unit[@name='eclipselink-unit']/non-jta-data-source", "jdbc/__default");{code}
> ...is not throwing an assertion failure ("eclipselink-unit" attribute is not present anywhere).
> This calls into question that we likely have tests giving false positives.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira