[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKDESC-18) import should close stream

[Tommy Tynjä (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613474#comment-12613474 ] 

Tommy Tynjä commented on SHRINKDESC-18:
---------------------------------------

A bit vague description, but I've commited some code for this issue: https://github.com/tommysdk/descriptors/commit/d3cc21d1bef153e2579a60a7044ed06c6654e9fe. Please review and give me feedback whether this is sufficient or not.

> import should close stream
> --------------------------
>
>                 Key: SHRINKDESC-18
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-18
>             Project: ShrinkWrap Descriptors
>          Issue Type: Feature Request
>          Components: api
>    Affects Versions: 0.1.0
>            Reporter: Dan Allen
>            Priority: Minor
>
> The import process should close the stream. After all, the main purpose of providing the stream is to slurp up all the contents. If the stream is left open, we throw the burden back on the developer to close it (and all the try/catch block headaches)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira