[shrinkwrap-issues] [JBoss JIRA] Updated: (SHRINKWRAP-110) Code Review and Action Items on ExtensionLoader/ServiceExtensionLoader

[Andrew Rubinger (JIRA)]

     [ https://issues.jboss.org/browse/SHRINKWRAP-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Rubinger updated SHRINKWRAP-110:
---------------------------------------

    Fix Version/s: 1.0.0-beta-1


> Code Review and Action Items on ExtensionLoader/ServiceExtensionLoader
> ----------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-110
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-110
>             Project: ShrinkWrap
>          Issue Type: Task
>          Components: api, impl-base
>            Reporter: Andrew Rubinger
>             Fix For: 1.0.0-beta-1
>
>
> We should do a community review on the ExtensionLoader API and ServiceExtensionLoader implementation.  This is the mechanism used to power Assignable.as();
> * Archives API should not expose extension loading configuration (SHRINKWRAP-102)
> * ServiceExtensionLoader needs documentation at class-level and on methods
> * ServiceExtensionLoader is not Thread-safe (or documented that this is the responsibility of the client, ArchiveBase, which does not sync access)
> * OK to always use TCCL at time of instantiation to find extension impls and classes?
> * ServiceExtensionLoader instance needs to be carried in the state of every archive?  Should some Assignable types be given access to different service extension loaders?  To me this looks like a singular point of configuration possibly warranting use of a Singleton.
> * All extension loading as a feature needs Wiki documentation

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira