[shrinkwrap-issues] [JBoss JIRA] Issue Comment Edited: (SHRINKWRAP-242) Get shrinkwrap to work from inside an OSGi framework

[Andrew Rubinger (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588979#comment-12588979 ] 

Andrew Rubinger edited comment on SHRINKWRAP-242 at 3/18/11 2:51 PM:
---------------------------------------------------------------------

OK, so I see what you've done here with the SWS.  We're getting closer to meeting in the middle.

Though this might not be necessary to have a separate SWS...instead of injecting Domain you could inject ArchiveFactory directly, which already has methods to mirror the static ShrinkWrap util.  This is actually why I made Domains, ArchiveFactories etc in the first place; so we could inject under a specific config (and this config would not interfere with other configs in the VM).

The only problem is that users would have to inject the ArchiveFactory as obtained from MSC, and any usage of ShrinkWrap utility methods would still be OSGi non-compatible.

Does this solve the issue?  Will be have cases of users STILL using ShrinkWrap.create() from within the OSGi environment?

I think of course we will.

So let's take the two-pronged approach:

1) Add to Domain/Configuration/ArchiveFactory a CL association to be used instead of TCCL.
2) Provide mechanism to apply a given CL for static usage (effectively configuring the default Domain/Configuration).  

The preferred usage inside AS will be to get an ArchiveFactory from MSC.  Failing that, use the static thing, which we'll configure properly (though the timing issues you mention will be at play).

Approve?

      was (Author: ALRubinger):
    OK, so I see what you've done here with the SWS.  We're getting closer to meeting in the middle.

Though this might not be necessary to have a separate SWS...instead of injecting Domain you could inject ArchiveFactory directly, which already has methods to mirror the static ShrinkWrap util.  This is actually why I made Domains, ArchiveFactories etc in the first place; so we could inject under a specific config (and this config would not interfere with other configs in the VM).

The only problem is that users would have to inject the ArchiveFactory as obtained from the, and any usage of ShrinkWrap utility methods would still be OSGi non-compatible.

Does this solve the problem?  Will be have cases of users STILL using ShrinkWrap.create() from within the OSGi environment?

I think of course we will.

So let's take the two-pronged approach:

1) Add to Domain/Configuration/ArchiveFactory a CL association to be used instead of TCCL.
2) Provide mechanism to apply a given CL for static usage (effectively configuring the default Domain/Configuration).  

The preferred usage inside AS will be to get an ArchiveFactory from MSC.  Failing that, use the static thing, which we'll configure properly (though the timing issues you mention will be at play).

Approve?
  
> Get shrinkwrap to work from inside an OSGi framework
> ----------------------------------------------------
>
>                 Key: SHRINKWRAP-242
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-242
>             Project: ShrinkWrap
>          Issue Type: Task
>    Affects Versions: 1.0.0-alpha-11
>            Reporter: David Bosschaert
>            Assignee: David Bosschaert
>            Priority: Critical
>             Fix For: 1.0.0-beta-1
>
>
> Currently there are issues around the use of Shrinkwrap in an OSGi framework. The libraries don't contain the necessary Manifest headers and just adding them causes classloading problems as the TCCL is used during the boot process.
> Shrinkwrap should be usable from within OSGi.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira