[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-264) DescriptorAsset should be a NamedAsset

[Andrew Rubinger (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591994#comment-12591994 ] 

Andrew Rubinger commented on SHRINKWRAP-264:
--------------------------------------------

Ivan:

Bingo.  It's all yours.  Make it so, and ping back here with a pull request. :)

Though in terms of implementation, I'd instead take a Descriptor in the ctor, and NamedAsset:getName() would delegate to the instance var descriptor.getName().  So no extra String member required; hang onto the whole Descriptor I think.

https://cla.jboss.org < Apply to the ShrinkWrap project
http://community.jboss.org/docs/DOC-14304 < Dev Instructions

> DescriptorAsset should be a NamedAsset
> --------------------------------------
>
>                 Key: SHRINKWRAP-264
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-264
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>          Components: ext-descriptors
>            Reporter: Aslak Knutsen
>
> Descriptors have a name, Descriptor.getDescriptorName, the DescriptorAsset should be a NamedAsset and use this name as default.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira