[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-242) Get shrinkwrap to work from inside an OSGi framework

[David Bosschaert (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592094#comment-12592094 ] 

David Bosschaert commented on SHRINKWRAP-242:
---------------------------------------------

{quote}This will ensure that the specified CL will be used for creating impl instances of Archives; is this the same as "loading the impl-base module"?{quote}
I think so, yes, as that module typically loads the Archive class, right?

{quote}So the above assumes that the CL passed in has visibility to both extension-sip and impl-base. If that's not true, then yes, we need a Collection of CLs to search.{quote}
If the extension-sip module depends on impl-base and re-exports its packages then it will provide visibility, otherwise it won't. Asking a user to create a classloader that delegates to more than one is a bit hairy IMHO. To support this use-case you could consider changing ConfigurationBuilder.classLoader(ClassLoasder cl) to ConfigurationBuilder.classLoaders(ClassLoasder ... cl) so you can pass as many in as you want... Or alternatively allow ConfigurationBuilder.classLoader(ClassLoader cl)  to be called multiple times to provide more than one...

> Get shrinkwrap to work from inside an OSGi framework
> ----------------------------------------------------
>
>                 Key: SHRINKWRAP-242
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-242
>             Project: ShrinkWrap
>          Issue Type: Task
>    Affects Versions: 1.0.0-alpha-11
>            Reporter: David Bosschaert
>            Assignee: David Bosschaert
>            Priority: Critical
>             Fix For: 1.0.0-beta-1
>
>
> Currently there are issues around the use of Shrinkwrap in an OSGi framework. The libraries don't contain the necessary Manifest headers and just adding them causes classloading problems as the TCCL is used during the boot process.
> Shrinkwrap should be usable from within OSGi.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira