[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-299) addAsResources() does not remove /classes segment when adding output directory to deployment

[Aslak Knutsen (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626462#comment-12626462 ] 

Aslak Knutsen commented on SHRINKWRAP-299:
------------------------------------------

Should addAsResource("target") end up adding the "target" directory and it's children, or should it function like "target/*"; only add children. 

"resource-location"/target/child vs "resource-location"/child

I think in most cases you don't want to include the added folder it self, but it's children. We could reuse the ssh copy concepts from linux here.

"target" means add the directory and it's children
"target/" means add the children

> addAsResources() does not remove /classes segment when adding output directory to deployment
> --------------------------------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-299
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-299
>             Project: ShrinkWrap
>          Issue Type: Bug
>    Affects Versions: 1.0.0-beta-3
>            Reporter: Lincoln Baxter III
>
> {code}
>    @Deployment(testable = false)
>    public static WebArchive getDeployment()
>    {
>       return ShrinkWrap
>                .create(WebArchive.class, "rewrite-test.war")
>                .addAsResource(new File("../api/target/classes/com"))
>                .addAsResource(new File("../api/target/classes/META-INF"))
>                .addAsResource(new File("../impl-servlet/target/classes/com"))
>                .addAsResource(new File("../impl-servlet/target/classes/META-INF"))
>                .addAsLibraries(DependencyResolvers.use(MavenDependencyResolver.class)
>                         .artifacts("org.jboss.weld.servlet:weld-servlet:1.1.1.Final")
>                         .resolveAs(GenericArchive.class))
>                .setWebXML("jetty-web.xml")
>                .addAsWebResource(
>                         new StringAsset("<beans/>"),
>                         ArchivePaths.create("WEB-INF/beans.xml"))
>                .addAsWebResource("jetty-env.xml",
>                         ArchivePaths.create("WEB-INF/jetty-env.xml"));
>    }
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira