[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-325) Maven based shrinkwrap WebArchive creator that adds all WEB-INF descriptors, classes, test classes and webapp resources too (not just dependencies and test dependencies)

[Geoffrey De Smet (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626477#comment-12626477 ] 

Geoffrey De Smet commented on SHRINKWRAP-325:
---------------------------------------------

JavaEE Api's will be scope=provided, so they shouldn't be added.

Arquillian and Shrinkwrap will be added, which is normal because their classes are used in our test classes (@Arquillian, ShrinkWrap.create...) at test runtime.

As for The container itself: The container itself should not be a scope=test dependency.
With a managed/remote container this isn't the case.
With embedded it is, but that smells like a design flaw not to separate those classpaths.
Maybe an embedded container should be a maven plugin?
Or maybe the embedded++ container is some day implementable and it can replace the current embedded container: it is an embedded container (so no zip to download), but starts in a separate process in it's own classpath.

As for the other random things? I've it's in the pom.xml it's probably not random but required :)

> Maven based shrinkwrap WebArchive creator that adds all WEB-INF descriptors, classes, test classes and webapp resources too (not just dependencies and test dependencies)
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-325
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-325
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>            Reporter: Geoffrey De Smet
>            Priority: Critical
>
> The MavenDependencyResolver is nice, but it does only half the job.
> We still have to manually add "target/guvnor-webapp-5.3.0-SNAPSHOT/"
> or "target/classes" and "target/test-classes" and "src/webapp/WEB-INF/*" files etc.
> But all that info is in the pom model, so it would be nice to have a feature as a facade for that.
> Something like
> {code}
> ShrinkWrap.createEntirelyFromMavenPom("pom.xml", includeEntireTestClasspath).
> {code}
> Note that it can include the entire test classpath (for helper classes under "target/test-classes" and dependencies such as Mockito).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira