[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-325) Maven based shrinkwrap WebArchive creator that adds all WEB-INF descriptors, classes, test classes and webapp resources too (not just dependencies and test dependencies)

[Geoffrey De Smet (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626522#comment-12626522 ] 

Geoffrey De Smet commented on SHRINKWRAP-325:
---------------------------------------------

> You haven't seen enough poms in your lifetime it seems.

I've seen and written plenty :) Let me clarify what I mean with following the pom.xml.

Despite all the black magic and random hacks that can happen in a pom.xml file, the output of the build is normally well defined and most (if not all) plugins use these directories:
- ${project.build.outputDirectory} defaults to target/classes
- ${project.build.testOutputDir} defaults to target/test-classes
- ${maven-war-plugin...:...webappDirectory} defaults to target/mywebapp-1.2.3-SNAPSHOT/ (see http://maven.apache.org/plugins/maven-war-plugin/war-mojo.html#webappDirectory )

Are there any random things examples which don't fall into that category? If they abuse the pom.xml that much,  personally I don't think this feature should support them.

> Maven based shrinkwrap WebArchive creator that adds all WEB-INF descriptors, classes, test classes and webapp resources too (not just dependencies and test dependencies)
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-325
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-325
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>            Reporter: Geoffrey De Smet
>            Priority: Critical
>
> The MavenDependencyResolver is nice, but it does only half the job.
> We still have to manually add "target/guvnor-webapp-5.3.0-SNAPSHOT/"
> or "target/classes" and "target/test-classes" and "src/webapp/WEB-INF/*" files etc.
> But all that info is in the pom model, so it would be nice to have a feature as a facade for that.
> Something like
> {code}
> ShrinkWrap.createEntirelyFromMavenPom("pom.xml", includeEntireTestClasspath).
> {code}
> Note that it can include the entire test classpath (for helper classes under "target/test-classes" and dependencies such as Mockito).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira