[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-325) ShrinkWrap.create(MavenImporter.class) that creates a WebArchive that adds all WEB-INF descriptors, classes, test classes and webapp resources too (not just dependencies and test dependencies)

[Geoffrey De Smet (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629146#comment-12629146 ] 

Geoffrey De Smet commented on SHRINKWRAP-325:
---------------------------------------------

@Marek: I am ok with adding finer-grained methods, so people can control to "only import the build output",
but the 1 course-grained facade method should still be there.

Most users, just want it "to just work", without having to fine tune all knobs and buttons. I 've wasted much time trial and erroring on all those knobs and buttons.
And in 80% of the cases, "to just work" means deploying the maven generated war with the test classpath added.
Yet, Marak's extra methods are useful for those 20% use cases where you need to do sometimes special.
General idea: configuration by exception.

> ShrinkWrap.create(MavenImporter.class) that creates a WebArchive that adds all WEB-INF descriptors, classes, test classes and webapp resources too (not just dependencies and test dependencies)
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-325
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-325
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>            Reporter: Geoffrey De Smet
>            Assignee: Karel Piwko
>            Priority: Critical
>
> The MavenDependencyResolver is nice, but it does only half the job.
> We still have to manually add "target/guvnor-webapp-5.3.0-SNAPSHOT/"
> or "target/classes" and "target/test-classes" and "src/webapp/WEB-INF/*" files etc.
> But all that info is in the pom model, so it would be nice to have a feature as a facade for that.
> Something like
> {code}
> ShrinkWrap.createEntirelyFromMavenPom("pom.xml", includeEntireTestClasspath).
> {code}
> Note that it can include the entire test classpath (for helper classes under "target/test-classes" and dependencies such as Mockito).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira