[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-26) Make Shrinkwrap resolver work in a modular environment

[Andrew Rubinger (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKRES-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12690231#comment-12690231 ] 

Andrew Rubinger commented on SHRINKRES-26:
------------------------------------------

The CL config must take place before the Resolver impl is instantiated.  In the new model I've made it an optional argument in "DependencyResolvers".
                
> Make Shrinkwrap resolver work in a modular environment
> ------------------------------------------------------
>
>                 Key: SHRINKRES-26
>                 URL: https://issues.jboss.org/browse/SHRINKRES-26
>             Project: ShrinkWrap Resolvers
>          Issue Type: Enhancement
>          Components: impl-maven
>    Affects Versions: 1.1.0-alpha-1
>            Reporter: Galder Zamarreño
>
> The subsystem I'm building requires dependencies of my war to downloaded and resolved at runtime or deploy time.
> So, that means that I need to create a set of JBoss AS7 modules for Shrinkwrap resolver. However, the way classloader works to load META-INF/services/org.jboss.shrinkwrap.resolver.api.maven.MavenDependencyResolver is a bit crap cos it uses thread context classloader in DependencyBuilderInstantiator.
> Can this be rewritten so that classloading can work in a modular environment as well?
> The problem is that the thread context classloader at runtime is:
> {code}ModuleClassLoader for Module "org.jboss.as.server:main" from local module loader @5d2412e7 (roots: ...){code}
> I can probably workaround this setting the module's classloader as thread context classloader temporarily, but this is not nice.
> Thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira