[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-85) MavenModelResolver clones (.newCopy()) shares mutable content

[Andrew Rubinger (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKRES-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733546#comment-12733546 ] 

Andrew Rubinger commented on SHRINKRES-85:
------------------------------------------

I've reviewed the pull request.

Can you show an example of how this leaks out to the user, however?  For instance, a test case which shows how calls through the API can cause a leak or otherwise muck with the internal state?  Not all copies of mutable object are necessarily harmful if they're isolated, so this issue is valid if we can prove that there's no such isolation.
                
> MavenModelResolver clones (.newCopy()) shares mutable content
> -------------------------------------------------------------
>
>                 Key: SHRINKRES-85
>                 URL: https://issues.jboss.org/browse/SHRINKRES-85
>             Project: ShrinkWrap Resolvers
>          Issue Type: Bug
>            Reporter: Michal Matloka
>            Assignee: Michal Matloka
>            Priority: Minor
>
> Contained RemoteRepository'ies are mutable but are passed to new copy not cloned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira