[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-432) ContainerBase.shallowCopy() is broken

[Michal Matloka (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737116#comment-12737116 ] 

Michal Matloka commented on SHRINKWRAP-432:
-------------------------------------------

I am wondering is this the most intuitive approach for the user. e.g. I would expect, that after doing shallow copy I would receive exactly the same structure - in this case containing those empty directories.
                
> ContainerBase.shallowCopy() is broken
> -------------------------------------
>
>                 Key: SHRINKWRAP-432
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-432
>             Project: ShrinkWrap
>          Issue Type: Bug
>            Reporter: Michal Matloka
>            Assignee: Vineet Reynolds
>              Labels: starter
>             Fix For: 1.1.1
>
>
> When archive contains directories, shallow copy throws exception due to
> {noformat}
>  for (final ArchivePath path : contents.keySet()) {
>      newArchive.add(contents.get(path).getAsset(), path);
>  }
> {noformat}
> because add(...) checks
> {noformat}
> Validate.notNull(asset, "No asset was specified");
> {noformat}
> it is possible that same bug concerns also ArchiveBase.shallowCopy()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira