[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-75) MavenStrategyStageBaseImpl.using(MavenResolutionStrategy) ignores MavenWorkingSessionImpl.settings.isOffline()

[Marco Rietveld (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKRES-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724468#comment-12724468 ] 

Marco Rietveld commented on SHRINKRES-75:
-----------------------------------------

Uhm.. the description above is incorrect (the code in session.getRemoteRepositories() _does_ make sure that the code works offline). This will turn into a jira about the error messages thrown by wagon.. still looking through the stack. 
                
> MavenStrategyStageBaseImpl.using(MavenResolutionStrategy) ignores MavenWorkingSessionImpl.settings.isOffline()
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: SHRINKRES-75
>                 URL: https://issues.jboss.org/browse/SHRINKRES-75
>             Project: ShrinkWrap Resolvers
>          Issue Type: Bug
>          Components: impl-maven
>    Affects Versions: 2.0.0-alpha-4
>            Reporter: Marco Rietveld
>            Assignee: Andrew Rubinger
>
> See [Line 115 on the 2.0.0-alpha-5-SNAPSHOT version ofMavenStrategyStageBaseImpl|https://github.com/shrinkwrap/resolver/blob/908b0c3e9e1723fc983d5782b6c316d539000b34/impl-maven/src/main/java/org/jboss/shrinkwrap/resolver/impl/maven/MavenStrategyStageBaseImpl.java#L115].
> The code there ignores the value of {{session.settings.isOffline()}}. It just retrieves the remote repository info and uses that to retrieve the maven dependencies. 
> This means that even if I use the code workaround that specify in SHRINKRES-74, the dependencies will still be retrieved "online" (instead of offline). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira