[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-389) Allow ShrinkWrap to overwrite existing ArchivePaths

Aslak Knutsen (JIRA) jira-events at lists.jboss.org
Thu Oct 18 07:42:01 EDT 2012


    [ https://issues.jboss.org/browse/SHRINKWRAP-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727643#comment-12727643 ] 

Aslak Knutsen commented on SHRINKWRAP-389:
------------------------------------------

How about getting the Archive instance in a overwrite enabled state.

e.g:

{code}
WebArchive war = ShrinkWrap.create(WebArchive.class):

war.add("x")
war.add("x") // throws Exception

war = war.enableOverwrite();
war.add("X")
war.add("X") // overwrites previous with no warning / exception
{code}

That would allow 'updated' code to hand of Overwrite enabled Archives to legacy code that don't check for it. For instance Arquillian 1.x can hand of a overwrite enabled archive to old container versions.
                
> Allow ShrinkWrap to overwrite existing ArchivePaths
> ---------------------------------------------------
>
>                 Key: SHRINKWRAP-389
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-389
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>            Reporter: Andrew Rubinger
>            Assignee: Michal Matloka
>              Labels: starter
>
> SHRINKWRAP-329 created a fail-fast (as opposed to silent no-op) approach to encountering the following case:
> {code}        // Create the new archive
>         final Archive<?> archive = createNewArchive();
>         // Put in an asset
>         final ArchivePath path = ArchivePaths.create("testPath");
>         archive.add(EmptyAsset.INSTANCE, path);
>         // Now try again with a new asset, and this should fail
>         try {
>             archive.add(new StringAsset("failContent"), path);
>         } catch (final IllegalOverwriteException ioe) {
>             // Good
>             return;
>         }{code}
> We need a feature now to disable this, effectively a boolean flag for each of the archive "add" methods to allow overwriting.  Will encompass API changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the shrinkwrap-issues mailing list