[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-183) Resolvers.configure(Class, ClassLoader) ignores ClassLoader?

[Karel Piwko (JIRA)]

     [ https://issues.jboss.org/browse/SHRINKRES-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karel Piwko resolved SHRINKRES-183.
-----------------------------------

    Fix Version/s: 2.2.0-alpha-3
       Resolution: Done


Nice catch Thomas!

Fix pushed upstream in https://github.com/shrinkwrap/resolver/commit/f28418141df3ecc22dcd1051ed8fdc58b73d50a4

> Resolvers.configure(Class,ClassLoader) ignores ClassLoader?
> -----------------------------------------------------------
>
>                 Key: SHRINKRES-183
>                 URL: https://issues.jboss.org/browse/SHRINKRES-183
>             Project: ShrinkWrap Resolvers
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: api
>    Affects Versions: 2.1.0, 2.2.0-alpha-2, 2.1.1
>            Reporter: Thomas Maslen
>            Assignee: Karel Piwko
>             Fix For: 2.2.0-alpha-3
>
>
> [No, I wasn't trying to use this, I just noticed it while looking at the source.  It looks to me like a regression, but you gents would be better judges of that than I am]
> The Resolvers.configure(Class,ClassLoader) method ignores its ClassLoader argument;  the only argument that it passes to ResolverSystemFactory.createFromUserView() is the Class.
> Offhand it looks like a cut-and-paste from the method above?
> If I'm reading Git right this was introduced in the fix for SHRINKRES-173 that went into 2.1.0, and it's present in 2.1.0 and above, including the current master.
> Happily, Resolvers.use(Class,ClassLoader) passes both arguments to ResolverSystemFactory as expected.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)