[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-479) Use default file ending for Archives with defined name

[Thorben Janssen (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12954856#comment-12954856 ] 

Thorben Janssen edited comment on SHRINKWRAP-479 at 3/21/14 4:49 AM:
---------------------------------------------------------------------

Yes, I saw this warning.
>From my point of view, this warning shows that a default file ending would be useful. ShrinkWrap already detects a possible error. So why not provide a default behaviour that avoids it?

>From my point of view, there should be no need to specify the obvious. It is better to provide a default behaviour that fits for most of the cases. And only if I want to do something special / deviate from the standard, I need to provide more information. 
Like it is the case with the Java EE annotations. The container provides the default behaviour without any additional information. But if I want to do something different, I can do this by providing more information.
                
      was (Author: th.janssen):
    Yes, I saw this warning.
>From my point of view, this warning shows that a default file ending would be useful. ShrinkWrap already detects a possible error. So why not provide a default behaviour that avoids it?

>From my point of view, there should be no need to specify the obvious. It is better to provide a default behaviour that fits for most of the cases. And only if I want to do something special / deviate from the standard, I need to provide more information. 
Like it is the case with the Java EE annotations. The container provides the default behaviour without any additional information. But if want to do something different, I can do this by providing more information.
                  
> Use default file ending for Archives with defined name
> ------------------------------------------------------
>
>                 Key: SHRINKWRAP-479
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-479
>             Project: ShrinkWrap
>          Issue Type: Feature Request
>            Reporter: Thorben Janssen
>
> If the name of an ShrinkWrap archive is defined during creation, the name has to include the correct file ending to ensure correct deployment in the container, e.g.:
> ShrinkWrap.create(EnterpriseArchive.class, "MyArchive.ear");
> In most of the cases the file ending is the default file ending of the specified archive type. In these cases there is no need to specify the obvious and it is just a source of error.
> Suggested change:
> - Archive implementation defines default file ending
> - default file ending is added to the specified archive name by default (if it does not match the end of the specified name)
> - add additional method to support archives with none standard file endings, e.g.: ShrinkWrap.create(Class<T> type, String archiveName, boolean useDefaultFileEnding)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira